diff options
author | George Goldberg <george@gberg.me> | 2018-04-27 10:53:38 +0100 |
---|---|---|
committer | George Goldberg <george@gberg.me> | 2018-04-27 10:53:38 +0100 |
commit | 2386acb3ddabd8827e21b1862c338a8b13a25de6 (patch) | |
tree | d9c5800bf168db532124db3c213c2607402894c6 /utils/jsonutils/json_test.go | |
parent | 7294644e9d74ca1512a730c597d61a97ccbcf10c (diff) | |
parent | 7abd6176e99d3f82711af51f8d75b3142ab73758 (diff) | |
download | chat-2386acb3ddabd8827e21b1862c338a8b13a25de6.tar.gz chat-2386acb3ddabd8827e21b1862c338a8b13a25de6.tar.bz2 chat-2386acb3ddabd8827e21b1862c338a8b13a25de6.zip |
Merge branch 'master' into advanced-permissions-phase-2
Diffstat (limited to 'utils/jsonutils/json_test.go')
-rw-r--r-- | utils/jsonutils/json_test.go | 237 |
1 files changed, 237 insertions, 0 deletions
diff --git a/utils/jsonutils/json_test.go b/utils/jsonutils/json_test.go new file mode 100644 index 000000000..b3986e87b --- /dev/null +++ b/utils/jsonutils/json_test.go @@ -0,0 +1,237 @@ +// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. +// See License.txt for license information. + +package jsonutils_test + +import ( + "encoding/json" + "reflect" + "testing" + + "github.com/pkg/errors" + "github.com/stretchr/testify/assert" + + "github.com/mattermost/mattermost-server/utils/jsonutils" +) + +func TestHumanizeJsonError(t *testing.T) { + t.Parallel() + + type testType struct{} + + testCases := []struct { + Description string + Data []byte + Err error + ExpectedErr string + }{ + { + "nil error", + []byte{}, + nil, + "", + }, + { + "non-special error", + []byte{}, + errors.New("test"), + "test", + }, + { + "syntax error, offset 17, middle of line 3", + []byte("line 1\nline 2\nline 3"), + &json.SyntaxError{ + // msg can't be set + Offset: 17, + }, + "parsing error at line 3, character 4: ", + }, + { + "unmarshal type error, offset 17, middle of line 3", + []byte("line 1\nline 2\nline 3"), + &json.UnmarshalTypeError{ + Value: "bool", + Type: reflect.TypeOf(testType{}), + Offset: 17, + Struct: "struct", + Field: "field", + }, + "parsing error at line 3, character 4: json: cannot unmarshal bool into Go struct field struct.field of type jsonutils_test.testType", + }, + } + + for _, testCase := range testCases { + testCase := testCase + t.Run(testCase.Description, func(t *testing.T) { + actual := jsonutils.HumanizeJsonError(testCase.Err, testCase.Data) + if testCase.ExpectedErr == "" { + assert.NoError(t, actual) + } else { + assert.EqualError(t, actual, testCase.ExpectedErr) + } + }) + } +} + +func TestNewHumanizedJsonError(t *testing.T) { + t.Parallel() + + type testType struct{} + + testCases := []struct { + Description string + Data []byte + Offset int64 + Err error + Expected *jsonutils.HumanizedJsonError + }{ + { + "nil error", + []byte{}, + 0, + nil, + nil, + }, + { + "offset -1, before start of string", + []byte("line 1\nline 2\nline 3"), + -1, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "invalid offset -1"), + }, + }, + { + "offset 0, start of string", + []byte("line 1\nline 2\nline 3"), + 0, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 1, character 1"), + Line: 1, + Character: 1, + }, + }, + { + "offset 5, end of line 1", + []byte("line 1\nline 2\nline 3"), + 5, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 1, character 6"), + Line: 1, + Character: 6, + }, + }, + { + "offset 6, new line at end end of line 1", + []byte("line 1\nline 2\nline 3"), + 6, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 1, character 7"), + Line: 1, + Character: 7, + }, + }, + { + "offset 7, start of line 2", + []byte("line 1\nline 2\nline 3"), + 7, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 2, character 1"), + Line: 2, + Character: 1, + }, + }, + { + "offset 12, end of line 2", + []byte("line 1\nline 2\nline 3"), + 12, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 2, character 6"), + Line: 2, + Character: 6, + }, + }, + { + "offset 13, newline at end of line 2", + []byte("line 1\nline 2\nline 3"), + 13, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 2, character 7"), + Line: 2, + Character: 7, + }, + }, + { + "offset 17, middle of line 3", + []byte("line 1\nline 2\nline 3"), + 17, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 3, character 4"), + Line: 3, + Character: 4, + }, + }, + { + "offset 19, end of string", + []byte("line 1\nline 2\nline 3"), + 19, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 3, character 6"), + Line: 3, + Character: 6, + }, + }, + { + "offset 20, offset = length of string", + []byte("line 1\nline 2\nline 3"), + 20, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 3, character 7"), + Line: 3, + Character: 7, + }, + }, + { + "offset 21, offset = length of string, after newline", + []byte("line 1\nline 2\nline 3\n"), + 21, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "parsing error at line 4, character 1"), + Line: 4, + Character: 1, + }, + }, + { + "offset 21, offset > length of string", + []byte("line 1\nline 2\nline 3"), + 21, + errors.New("message"), + &jsonutils.HumanizedJsonError{ + Err: errors.Wrap(errors.New("message"), "invalid offset 21"), + }, + }, + } + + for _, testCase := range testCases { + testCase := testCase + t.Run(testCase.Description, func(t *testing.T) { + actual := jsonutils.NewHumanizedJsonError(testCase.Err, testCase.Data, testCase.Offset) + if testCase.Expected != nil && actual.Err != nil { + if assert.EqualValues(t, testCase.Expected.Err.Error(), actual.Err.Error()) { + actual.Err = testCase.Expected.Err + } + } + assert.Equal(t, testCase.Expected, actual) + }) + } +} |