diff options
author | Jesse Hallam <jesse.hallam@gmail.com> | 2018-07-13 10:29:50 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-07-13 10:29:50 -0400 |
commit | 17f211c393772f30922bac595592e3fe60c2ef25 (patch) | |
tree | 4f8dfbe7949022d5da2de2db6d7b762e74fb4582 /plugin/supervisor_test.go | |
parent | 5ddb08dcb47f938c9ac3a3e6338d9b3cc61c20a7 (diff) | |
download | chat-17f211c393772f30922bac595592e3fe60c2ef25.tar.gz chat-17f211c393772f30922bac595592e3fe60c2ef25.tar.bz2 chat-17f211c393772f30922bac595592e3fe60c2ef25.zip |
MM-11292: clean up plugins GoDoc (#9109)
* clean up plugins GoDoc:
- eliminate plugin.NewBlankContext() as unnecessary
- export ValidIdRegex as a string vs. the less readable var
- add/update various documentation strings
- hide everything by default, except where used by client plugins or the mattermost-server. The exception to this rule are the `*(Args|Returns)` structs which must be public for go-plugin, but are now prefixed with `Z_` with a warning not to use.
- include a top-level example to get plugin authors started
This is not a breaking change for existing plugins compiled against
plugins-v2.
* remove commented out ServeHTTPResponseWriter
* update examples to match developer docs
* add missing plugin/doc.go license header
Diffstat (limited to 'plugin/supervisor_test.go')
-rw-r--r-- | plugin/supervisor_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/plugin/supervisor_test.go b/plugin/supervisor_test.go index ddd04696f..19d0499e5 100644 --- a/plugin/supervisor_test.go +++ b/plugin/supervisor_test.go @@ -73,7 +73,7 @@ func testSupervisor(t *testing.T) { ConsoleLevel: "error", EnableFile: false, }) - supervisor, err := NewSupervisor(bundle, log, &api) + supervisor, err := newSupervisor(bundle, log, &api) require.NoError(t, err) supervisor.Shutdown() } @@ -92,7 +92,7 @@ func testSupervisor_InvalidExecutablePath(t *testing.T) { ConsoleLevel: "error", EnableFile: false, }) - supervisor, err := NewSupervisor(bundle, log, nil) + supervisor, err := newSupervisor(bundle, log, nil) assert.Nil(t, supervisor) assert.Error(t, err) } @@ -111,7 +111,7 @@ func testSupervisor_NonExistentExecutablePath(t *testing.T) { ConsoleLevel: "error", EnableFile: false, }) - supervisor, err := NewSupervisor(bundle, log, nil) + supervisor, err := newSupervisor(bundle, log, nil) require.Error(t, err) require.Nil(t, supervisor) } @@ -141,7 +141,7 @@ func testSupervisor_StartTimeout(t *testing.T) { ConsoleLevel: "error", EnableFile: false, }) - supervisor, err := NewSupervisor(bundle, log, nil) + supervisor, err := newSupervisor(bundle, log, nil) require.Error(t, err) require.Nil(t, supervisor) } |