diff options
author | Saturnino Abril <saturnino.abril@gmail.com> | 2018-04-06 21:41:45 +0800 |
---|---|---|
committer | Derrick Anderson <derrick@andersonwebstudio.com> | 2018-04-06 09:41:45 -0400 |
commit | e16217166dd39fe75a9dc995c2d4e77cb7485143 (patch) | |
tree | 984aef02268d4c8786e849b949ec680589518e34 /app | |
parent | f7dd715052741097616816f9cce600006e5c2290 (diff) | |
download | chat-e16217166dd39fe75a9dc995c2d4e77cb7485143.tar.gz chat-e16217166dd39fe75a9dc995c2d4e77cb7485143.tar.bz2 chat-e16217166dd39fe75a9dc995c2d4e77cb7485143.zip |
fix out of channel mentions for mentioned word with valid punctuations (#8585)
Diffstat (limited to 'app')
-rw-r--r-- | app/notification.go | 12 | ||||
-rw-r--r-- | app/notification_test.go | 6 |
2 files changed, 10 insertions, 8 deletions
diff --git a/app/notification.go b/app/notification.go index 0ea03c9d9..5b7ed5ad2 100644 --- a/app/notification.go +++ b/app/notification.go @@ -897,7 +897,9 @@ func GetExplicitMentions(message string, keywords map[string][]string) *Explicit continue } - if strings.ContainsAny(word, ".-:") { + if _, ok := systemMentions[word]; !ok && strings.HasPrefix(word, "@") { + ret.OtherPotentialMentions = append(ret.OtherPotentialMentions, word[1:]) + } else if strings.ContainsAny(word, ".-:") { // This word contains a character that may be the end of a sentence, so split further splitWords := strings.FieldsFunc(word, func(c rune) bool { return c == '.' || c == '-' || c == ':' @@ -908,16 +910,10 @@ func GetExplicitMentions(message string, keywords map[string][]string) *Explicit continue } if _, ok := systemMentions[splitWord]; !ok && strings.HasPrefix(splitWord, "@") { - username := splitWord[1:] - ret.OtherPotentialMentions = append(ret.OtherPotentialMentions, username) + ret.OtherPotentialMentions = append(ret.OtherPotentialMentions, splitWord[1:]) } } } - - if _, ok := systemMentions[word]; !ok && strings.HasPrefix(word, "@") { - username := word[1:] - ret.OtherPotentialMentions = append(ret.OtherPotentialMentions, username) - } } } diff --git a/app/notification_test.go b/app/notification_test.go index c72610b60..1abdd3d61 100644 --- a/app/notification_test.go +++ b/app/notification_test.go @@ -234,6 +234,12 @@ func TestGetExplicitMentions(t *testing.T) { OtherPotentialMentions: []string{"potential"}, }, }, + "PotentialOutOfChannelUserWithPeriod": { + Message: "this is an message for @potential.user", + Expected: &ExplicitMentions{ + OtherPotentialMentions: []string{"potential.user"}, + }, + }, "InlineCode": { Message: "`this shouldn't mention @channel at all`", Keywords: map[string][]string{}, |