Don't use global app for api / api4 tests (#7528)

* don't use global app for api / api4 tests

* put sleep back. we're gonna have to do some goroutine wrangling

* fix oauth test config assumptions

* jobs package, i'm comin' for you next

* app test fix

* try increasing sleep a little

1 files changed, 10 insertions, 0 deletions

diff --git a/api/preference_test.go b/api/preference_test.go
index 833e49a65..3948ca2c9 100644
--- a/api/preference_test.go
+++ b/api/preference_test.go
@@ -11,6 +11,8 @@ import (
 
 func TestGetAllPreferences(t *testing.T) {
 	th := Setup().InitBasic()
+	defer th.TearDown()
+
 	Client := th.BasicClient
 	user1 := th.BasicUser
 
@@ -53,6 +55,8 @@ func TestGetAllPreferences(t *testing.T) {
 
 func TestSetPreferences(t *testing.T) {
 	th := Setup().InitBasic()
+	defer th.TearDown()
+
 	Client := th.BasicClient
 	user1 := th.BasicUser
 
@@ -89,6 +93,8 @@ func TestSetPreferences(t *testing.T) {
 
 func TestGetPreferenceCategory(t *testing.T) {
 	th := Setup().InitBasic()
+	defer th.TearDown()
+
 	Client := th.BasicClient
 	user1 := th.BasicUser
 
@@ -133,6 +139,8 @@ func TestGetPreferenceCategory(t *testing.T) {
 
 func TestGetPreference(t *testing.T) {
 	th := Setup().InitBasic()
+	defer th.TearDown()
+
 	Client := th.BasicClient
 	user := th.BasicUser
 
@@ -165,6 +173,8 @@ func TestGetPreference(t *testing.T) {
 
 func TestDeletePreferences(t *testing.T) {
 	th := Setup().InitBasic()
+	defer th.TearDown()
+
 	Client := th.BasicClient
 	user1 := th.BasicUser