summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorey Hulen <corey@hulen.com>2015-11-05 14:04:47 -0800
committerCorey Hulen <corey@hulen.com>2015-11-05 14:04:47 -0800
commit7b7491a438e413a2030a7ed3ef0cba4605aa2e8d (patch)
tree588fb7ad0695038e3b8389d94ec4638ad0601148
parent6418b78f1c8d7b9bba240ef5638e9e2a1613c3e5 (diff)
parent7ccb4037ab02835fe0511aa221789c9525fb1ed1 (diff)
downloadchat-7b7491a438e413a2030a7ed3ef0cba4605aa2e8d.tar.gz
chat-7b7491a438e413a2030a7ed3ef0cba4605aa2e8d.tar.bz2
chat-7b7491a438e413a2030a7ed3ef0cba4605aa2e8d.zip
Merge pull request #1302 from mattermost/it33-patch-1
Noting random build failures
-rw-r--r--CONTRIBUTING.md2
1 files changed, 2 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index db8c90023..bd571efed 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -46,5 +46,7 @@ git checkout -b <branch name>
- For example, for a ticket ID `PLT-394` start your comment with: `PLT-394:`. See [previously closed pull requests](https://github.com/mattermost/platform/pulls?q=is%3Apr+is%3Aclosed) for examples
3. Once submitted, your pull request will be checked via an automated build process and will be reviewed by at least two members of the Mattermost core team, who may either accept the PR or follow-up with feedback. It would then get merged into `master` for the next release
+ 1. If the build fails, check the error log to narrow down the reason
+ 2. Sometimes one of the multiple build tests will randomly fail due to issues in Travis CI so if you see just one build failure and no clear error message it may be a random issue. Add a comment so the reviewer for your change can re-run the build for you, or close the PR and re-submit and that typically clears the issue
4. If you've included your mailing address in Step 1, you'll be receiving a [Limited Edition Mattermost Mug](http://forum.mattermost.org/t/limited-edition-mattermost-mugs/143) as a thank you gift after your first pull request has been accepted