From c2e58dcb62a5340f4922d5986342ef821ce4b2b3 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Thu, 6 Dec 2018 01:49:57 +0200 Subject: - Partial fix to unchecked rule, and tips for fixing. Related #1972 --- models/checklistItems.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to 'models') diff --git a/models/checklistItems.js b/models/checklistItems.js index 0f85019e..9867dd94 100644 --- a/models/checklistItems.js +++ b/models/checklistItems.js @@ -141,10 +141,23 @@ function publishChekListUncompleted(userId, doc){ const boardId = card.boardId; const checklistId = doc.checklistId; const checkList = Checklists.findOne({_id:checklistId}); + // BUGS in IFTTT Rules: https://github.com/wekan/wekan/issues/1972 + // Currently in checklist all are set as uncompleted/not checked, + // IFTTT Rule does not move card to other list. + // If following line is negated/changed to: + // if(!checkList.isFinished()){ + // then unchecking of any checkbox will move card to other list, + // even when all checkboxes are not yet unchecked. + // What is correct code for only moving when all in list is unchecked? + // TIPS: Finding files, ignoring some directories with grep -v: + // cd wekan + // find . | xargs grep 'count' -sl | grep -v .meteor | grep -v node_modules | grep -v .build + // Maybe something related here? + // wekan/client/components/rules/triggers/checklistTriggers.js if(checkList.isFinished()){ const act = { userId, - activityType: 'checklistUncompleted', + activityType: 'uncompleteChecklist', cardId: doc.cardId, boardId, checklistId: doc.checklistId, -- cgit v1.2.3-1-g7c22