From a666883986073f9b2f00fce0b9be30d709628b22 Mon Sep 17 00:00:00 2001 From: "Sam X. Chen" Date: Tue, 13 Aug 2019 09:28:42 -0400 Subject: Addfeature: showing action in system message when user deleted/edited comments, plus changing email content \n to
--- client/components/activities/activities.jade | 5 +++++ i18n/en.i18n.json | 2 ++ server/notifications/email.js | 4 ++-- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/client/components/activities/activities.jade b/client/components/activities/activities.jade index 5be953b6..deb73072 100644 --- a/client/components/activities/activities.jade +++ b/client/components/activities/activities.jade @@ -201,6 +201,7 @@ template(name="cardActivities") .activity-checklist(href="{{ card.absoluteUrl }}") +viewer = checklistItem.title + if(currentData.timeKey) | {{{_ activityType }}} = ' ' @@ -215,6 +216,10 @@ template(name="cardActivities") | {{{_ activityType currentData.timeValue}}} + if($eq activityType 'deleteComment') + | {{{_ 'activity-deleteComment' currentData.commentId}}}. + if($eq activityType 'editComment') + | {{{_ 'activity-editComment' currentData.commentId}}}. if($eq activityType 'addComment') +inlinedForm(classNames='js-edit-comment') +editor(autofocus=true) diff --git a/i18n/en.i18n.json b/i18n/en.i18n.json index 4501fffb..84b3dac1 100644 --- a/i18n/en.i18n.json +++ b/i18n/en.i18n.json @@ -73,6 +73,8 @@ "activity-unchecked-item-card": "unchecked %s in checklist %s", "activity-checklist-completed-card": "completed checklist __checklist__ at card __card__ at list __list__ at swimlane __swimlane__ at board __board__", "activity-checklist-uncompleted-card": "uncompleted the checklist %s", + "activity-editComment": "edited comment %s", + "activity-deleteComment": "deleted comment %s", "add-attachment": "Add Attachment", "add-board": "Add Board", "add-card": "Add Card", diff --git a/server/notifications/email.js b/server/notifications/email.js index deb140a6..0373deb0 100644 --- a/server/notifications/email.js +++ b/server/notifications/email.js @@ -13,9 +13,9 @@ Meteor.startup(() => { const lan = user.getLanguage(); const subject = TAPi18n.__(title, params, lan); // the original function has a fault, i believe the title should be used according to original author const existing = user.getEmailBuffer().length > 0; - const text = `${existing ? `\n${subject}\n` : ''}${ + const text = `${existing ? `
\n${subject}
\n` : ''}${ params.user - } ${TAPi18n.__(description, quoteParams, lan)}\n${params.url}`; + } ${TAPi18n.__(description, quoteParams, lan)}
\n${params.url}`; user.addEmailBuffer(text); -- cgit v1.2.3-1-g7c22