From 8d81aca4398c29eaa5236b92053c33a957b1bcf4 Mon Sep 17 00:00:00 2001 From: Benjamin Tissoires Date: Fri, 25 Jan 2019 14:10:10 +0100 Subject: api: fix set_board_member_permission If the data is passed as a boolean, through json, data.toLowerCase() raises an error. Also define query which we are returning in case of success. --- models/boards.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/models/boards.js b/models/boards.js index 99480ca7..1d6472cc 100644 --- a/models/boards.js +++ b/models/boards.js @@ -1113,9 +1113,14 @@ if (Meteor.isServer) { Authentication.checkBoardAccess(req.userId, boardId); const board = Boards.findOne({ _id: boardId }); function isTrue(data){ - return data.toLowerCase() === 'true'; + try { + return data.toLowerCase() === 'true'; + } + catch (error) { + return data; + } } - board.setMemberPermission(memberId, isTrue(isAdmin), isTrue(isNoComments), isTrue(isCommentOnly), req.userId); + const query = board.setMemberPermission(memberId, isTrue(isAdmin), isTrue(isNoComments), isTrue(isCommentOnly), req.userId); JsonRoutes.sendResult(res, { code: 200, -- cgit v1.2.3-1-g7c22