From 3b2b1087447bc8613baa8254bfec55e3d485bdc4 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Tue, 16 Jun 2020 19:55:56 +0300 Subject: Fix: Unable to delete a custom field in a board. Thanks to xet7 ! Fixes #2605 --- models/customFields.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/models/customFields.js b/models/customFields.js index 9df635ba..83b47fc0 100644 --- a/models/customFields.js +++ b/models/customFields.js @@ -172,16 +172,14 @@ function customFieldDeletion(userId, doc) { function customFieldEdit(userId, doc) { const card = Cards.findOne(doc.cardId); const customFieldValue = Activities.findOne({ customFieldId: doc._id }).value; - const boardId = card.boardId; - //boardId: doc.boardIds[0], // We are creating a customField, it has only one boardId Activities.insert({ userId, activityType: 'setCustomField', - boardId, + boardId: doc.boardIds[0], // We are creating a customField, it has only one boardId customFieldId: doc._id, customFieldValue, - listId: card.listId, - swimlaneId: card.swimlaneId, + listId: doc.listId, + swimlaneId: doc.swimlaneId, }); } @@ -206,8 +204,8 @@ if (Meteor.isServer) { Activities.remove({ customFieldId: doc._id, boardId: modifier.$pull.boardIds, - listId: card.listId, - swimlaneId: card.swimlaneId, + listId: doc.listId, + swimlaneId: doc.swimlaneId, }); } else if (_.contains(fieldNames, 'boardIds') && modifier.$push) { Activities.insert({ -- cgit v1.2.3-1-g7c22