diff options
author | Maxime Quandalle <maxime@quandalle.com> | 2015-10-22 04:02:12 +0200 |
---|---|---|
committer | Maxime Quandalle <maxime@quandalle.com> | 2015-10-22 18:13:12 +0200 |
commit | aa974aa54ab6e5b7db7450206d12b44ffb3a0306 (patch) | |
tree | b501ee16fa630e19b95d99ffc3984e30301e096a /client/lib/multiSelection.js | |
parent | c6b12dc5ada1b37d759796fefe0dbc5b327f130c (diff) | |
download | wekan-aa974aa54ab6e5b7db7450206d12b44ffb3a0306.tar.gz wekan-aa974aa54ab6e5b7db7450206d12b44ffb3a0306.tar.bz2 wekan-aa974aa54ab6e5b7db7450206d12b44ffb3a0306.zip |
Prefer ES5 methods over underscore utilities
Since 07cc454 (ie the switch to Meteor 1.2) we includes the `es5-shim`
polyfill to support methods like `Array.prototype.forEach` in a
consistent way across all supported browsers (IE8+).
MDG recently released a blog post recommending the use of these native
methods instead of underscore [0]. We know follow this recommendation.
This commit also favor some ES6 features (argument defaults,
destructing assignment) in places where we didn’t use them.
[0]: http://info.meteor.com/blog/es2015-get-started
Diffstat (limited to 'client/lib/multiSelection.js')
-rw-r--r-- | client/lib/multiSelection.js | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/client/lib/multiSelection.js b/client/lib/multiSelection.js index c2bb2bbc..eeb2015d 100644 --- a/client/lib/multiSelection.js +++ b/client/lib/multiSelection.js @@ -119,12 +119,13 @@ MultiSelection = { } }, - toggle(cardIds, options) { + toggle(cardIds, options = {}) { cardIds = _.isString(cardIds) ? [cardIds] : cardIds; - options = _.extend({ + options = { add: true, remove: true, - }, options || {}); + ...options, + }; if (!this.isActive()) { this.reset(); @@ -133,7 +134,7 @@ MultiSelection = { const selectedCards = this._selectedCards.get(); - _.each(cardIds, (cardId) => { + cardIds.forEach((cardId) => { const indexOfCard = selectedCards.indexOf(cardId); if (options.remove && indexOfCard > -1) |