diff options
author | Lauri Ojansivu <x@xet7.org> | 2018-12-24 18:27:49 +0200 |
---|---|---|
committer | Lauri Ojansivu <x@xet7.org> | 2018-12-24 18:27:49 +0200 |
commit | 236c99b39f7b89bf0751684b88ebfaa331211d3e (patch) | |
tree | a5488cfd8862aae6a40d2cceeab43ed53274750e | |
parent | 5488b68b9b603a7e3caab7d21f1d0e0d7eeecf00 (diff) | |
parent | 67b76558fc0ff25fa01ce20cbb29a26b6f7aebbd (diff) | |
download | wekan-236c99b39f7b89bf0751684b88ebfaa331211d3e.tar.gz wekan-236c99b39f7b89bf0751684b88ebfaa331211d3e.tar.bz2 wekan-236c99b39f7b89bf0751684b88ebfaa331211d3e.zip |
Merge branch 'edge' into meteor-1.8
-rw-r--r-- | CHANGELOG.md | 13 | ||||
-rwxr-xr-x | client/components/main/editor.js | 13 | ||||
-rw-r--r-- | client/components/main/layouts.jade | 1 | ||||
-rw-r--r-- | client/components/main/layouts.js | 109 | ||||
-rw-r--r-- | client/components/settings/connectionMethod.jade | 6 | ||||
-rw-r--r-- | client/components/settings/connectionMethod.js | 34 | ||||
-rw-r--r-- | docker-compose.yml | 13 | ||||
-rw-r--r-- | i18n/fa.i18n.json | 4 | ||||
-rw-r--r-- | package.json | 2 | ||||
-rw-r--r-- | sandstorm-pkgdef.capnp | 7 |
10 files changed, 117 insertions, 85 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 169efdf7..f1422939 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,17 @@ -# Upcoming Wekan release +# v1.96 2018-12-24 Wekan release This release adds the following new features: -- [Combine all docker-compose.yml files](https://github.com/wekan/wekan/commit/3f948ba49ba7266c436ff138716bdcae9e879903). Thanks to xet7. +- [Combine all docker-compose.yml files](https://github.com/wekan/wekan/commit/3f948ba49ba7266c436ff138716bdcae9e879903). -Thanks to above GitHub users for their contributions. +and tries to fix following bugs: + +- Revert "Improve authentication" and "Default Authentication Method" + to make login work again. +- Fixes to docker-compose.yml so that Wekan Meteor 1.6.x version would work. + Most likely Meteor 1.8.x version is still broken. + +Thanks to GitHub user xet7 contributions. # v1.95 2018-12-21 Wekan release diff --git a/client/components/main/editor.js b/client/components/main/editor.js index 152f69e2..20ece562 100755 --- a/client/components/main/editor.js +++ b/client/components/main/editor.js @@ -9,12 +9,10 @@ Template.editor.onRendered(() => { match: /\B@([\w.]*)$/, search(term, callback) { const currentBoard = Boards.findOne(Session.get('currentBoard')); - if (currentBoard) { - callback(currentBoard.activeMembers().map((member) => { - const username = Users.findOne(member.userId).username; - return username.includes(term) ? username : null; - }).filter(Boolean)); - } + callback(currentBoard.activeMembers().map((member) => { + const username = Users.findOne(member.userId).username; + return username.includes(term) ? username : null; + }).filter(Boolean)); }, template(value) { return value; @@ -39,9 +37,6 @@ const at = HTML.CharRef({html: '@', str: '@'}); Blaze.Template.registerHelper('mentions', new Template('mentions', function() { const view = this; const currentBoard = Boards.findOne(Session.get('currentBoard')); - if (!currentBoard) { - return HTML.Raw(''); - } const knowedUsers = currentBoard.members.map((member) => { const u = Users.findOne(member.userId); if(u){ diff --git a/client/components/main/layouts.jade b/client/components/main/layouts.jade index 1c22fee6..55ee2686 100644 --- a/client/components/main/layouts.jade +++ b/client/components/main/layouts.jade @@ -23,6 +23,7 @@ template(name="userFormsLayout") br section.auth-dialog +Template.dynamic(template=content) + +connectionMethod if isCas .at-form button#cas(class='at-btn submit' type='submit') {{casSignInLabel}} diff --git a/client/components/main/layouts.js b/client/components/main/layouts.js index 89dcca2d..a50d167e 100644 --- a/client/components/main/layouts.js +++ b/client/components/main/layouts.js @@ -6,14 +6,29 @@ const i18nTagToT9n = (i18nTag) => { return i18nTag; }; -Template.userFormsLayout.onCreated(function() { - Meteor.call('getDefaultAuthenticationMethod', (error, result) => { - this.data.defaultAuthenticationMethod = new ReactiveVar(error ? undefined : result); - }); +const validator = { + set(obj, prop, value) { + if (prop === 'state' && value !== 'signIn') { + $('.at-form-authentication').hide(); + } else if (prop === 'state' && value === 'signIn') { + $('.at-form-authentication').show(); + } + // The default behavior to store the value + obj[prop] = value; + // Indicate success + return true; + }, +}; + +Template.userFormsLayout.onCreated(() => { Meteor.subscribe('setting'); + }); Template.userFormsLayout.onRendered(() => { + + AccountsTemplates.state.form.keys = new Proxy(AccountsTemplates.state.form.keys, validator); + const i18nTag = navigator.language; if (i18nTag) { T9n.setLanguage(i18nTagToT9n(i18nTag)); @@ -86,11 +101,13 @@ Template.userFormsLayout.events({ } }); }, - 'click #at-btn'(event, instance) { - const email = $('#at-field-username_and_email').val(); - const password = $('#at-field-password').val(); - - if (FlowRouter.getRouteName() !== 'atSignIn' || password === '' || email === '') { + 'click #at-btn'(event) { + /* All authentication method can be managed/called here. + !! DON'T FORGET to correctly fill the fields of the user during its creation if necessary authenticationMethod : String !! + */ + const authenticationMethodSelected = $('.select-authentication').val(); + // Local account + if (authenticationMethodSelected === 'password') { return; } @@ -98,11 +115,29 @@ Template.userFormsLayout.events({ event.preventDefault(); event.stopImmediatePropagation(); - Meteor.subscribe('user-authenticationMethod', email, { - onReady() { - return authentication.call(this, instance, email, password); - }, - }); + const email = $('#at-field-username_and_email').val(); + const password = $('#at-field-password').val(); + + // Ldap account + if (authenticationMethodSelected === 'ldap') { + // Check if the user can use the ldap connection + Meteor.subscribe('user-authenticationMethod', email, { + onReady() { + const user = Users.findOne(); + if (user === undefined || user.authenticationMethod === 'ldap') { + // Use the ldap connection package + Meteor.loginWithLDAP(email, password, function(error) { + if (!error) { + // Connection + return FlowRouter.go('/'); + } + return error; + }); + } + return this.stop(); + }, + }); + } }, }); @@ -111,49 +146,3 @@ Template.defaultLayout.events({ Modal.close(); }, }); - -function authentication(instance, email, password) { - const user = Users.findOne(); - - // Authentication with password - if (user && user.authenticationMethod === 'password') { - $('#at-pwd-form').submit(); - return this.stop(); - } - - const authenticationMethod = user - ? user.authenticationMethod - : instance.data.defaultAuthenticationMethod.get(); - - switch (authenticationMethod) { - case 'ldap': - // Use the ldap connection package - Meteor.loginWithLDAP(email, password, function(error) { - if (error) { - displayError('error-ldap-login'); - return this.stop(); - } else { - return FlowRouter.go('/'); - } - }); - break; - - default: - displayError('error-undefined'); - } - - return this.stop(); -} - -function displayError(code) { - const translated = TAPi18n.__(code); - - if (translated === code) { - return; - } - - if(!$('.at-error').length) { - $('.at-pwd-form').before('<div class="at-error"><p></p></div>'); - } - $('.at-error p').text(translated); -} diff --git a/client/components/settings/connectionMethod.jade b/client/components/settings/connectionMethod.jade new file mode 100644 index 00000000..ac4c8c64 --- /dev/null +++ b/client/components/settings/connectionMethod.jade @@ -0,0 +1,6 @@ +template(name='connectionMethod') + div.at-form-authentication + label {{_ 'authentication-method'}} + select.select-authentication + each authentications + option(value="{{value}}") {{_ value}} diff --git a/client/components/settings/connectionMethod.js b/client/components/settings/connectionMethod.js new file mode 100644 index 00000000..9fe8f382 --- /dev/null +++ b/client/components/settings/connectionMethod.js @@ -0,0 +1,34 @@ +Template.connectionMethod.onCreated(function() { + this.authenticationMethods = new ReactiveVar([]); + + Meteor.call('getAuthenticationsEnabled', (_, result) => { + if (result) { + // TODO : add a management of different languages + // (ex {value: ldap, text: TAPi18n.__('ldap', {}, T9n.getLanguage() || 'en')}) + this.authenticationMethods.set([ + {value: 'password'}, + // Gets only the authentication methods availables + ...Object.entries(result).filter((e) => e[1]).map((e) => ({value: e[0]})), + ]); + } + + // If only the default authentication available, hides the select boxe + const content = $('.at-form-authentication'); + if (!(this.authenticationMethods.get().length > 1)) { + content.hide(); + } else { + content.show(); + } + }); +}); + +Template.connectionMethod.onRendered(() => { + // Moves the select boxe in the first place of the at-pwd-form div + $('.at-form-authentication').detach().prependTo('.at-pwd-form'); +}); + +Template.connectionMethod.helpers({ + authentications() { + return Template.instance().authenticationMethods.get(); + }, +}); diff --git a/docker-compose.yml b/docker-compose.yml index 804a127f..9d635a33 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -90,11 +90,11 @@ services: wekandb: #------------------------------------------------------------------------------------- # ==== MONGODB AND METEOR VERSION ==== - # a) For Wekan Meteor 1.8.x version at meteor-1.8 branch, use mongo 4.x - image: mongo:4.0.4 + # a) CURRENTLY BROKEN: For Wekan Meteor 1.8.x version at meteor-1.8 branch, use mongo 4.x + # image: mongo:4.0.4 # b) For Wekan Meteor 1.6.x version at master/devel/edge branches. # Only for Snap and Sandstorm while they are not upgraded yet to Meteor 1.8.x - # image: mongo:3.2.21 + image: mongo:3.2.21 #------------------------------------------------------------------------------------- container_name: wekan-db restart: always @@ -110,12 +110,12 @@ services: wekan: #------------------------------------------------------------------------------------- # ==== MONGODB AND METEOR VERSION ==== - # a) For Wekan Meteor 1.8.x version at meteor-1.8 branch, + # a) CURRENTLY BROKEN: For Wekan Meteor 1.8.x version at meteor-1.8 branch, # using https://quay.io/wekan/wekan automatic builds - image: quay.io/wekan/wekan:meteor-1.8 + # image: quay.io/wekan/wekan:meteor-1.8 # b) For Wekan Meteor 1.6.x version at master/devel/edge branches. # Only for Snap and Sandstorm while they are not upgraded yet to Meteor 1.8.x - # image: quay.io/wekan/wekan + image: quay.io/wekan/wekan # c) Using specific Meteor 1.6.x version tag: # image: quay.io/wekan/wekan:v1.95 # c) Using Docker Hub automatic builds https://hub.docker.com/r/wekanteam/wekan @@ -128,6 +128,7 @@ services: - wekan-tier #------------------------------------------------------------------------------------- # ==== BUILD wekan-app DOCKER CONTAINER FROM SOURCE, if you uncomment these ==== + # ==== and use commands: docker-compose up -d --build #build: # context: . # dockerfile: Dockerfile diff --git a/i18n/fa.i18n.json b/i18n/fa.i18n.json index e72048d8..f46e9cfc 100644 --- a/i18n/fa.i18n.json +++ b/i18n/fa.i18n.json @@ -620,6 +620,6 @@ "hide-logo": "مخفی سازی نماد", "add-custom-html-after-body-start": "افزودن کد های HTML بعد از <body> شروع", "add-custom-html-before-body-end": "افزودن کد های HTML قبل از </body> پایان", - "error-undefined": "Something went wrong", - "error-ldap-login": "An error occurred while trying to login" + "error-undefined": "یک اشتباه رخ داده شده است", + "error-ldap-login": "هنگام تلاش برای ورود به یک خطا رخ داد" }
\ No newline at end of file diff --git a/package.json b/package.json index f753fb46..034db32a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "wekan", - "version": "v1.95.0", + "version": "v1.96.0", "description": "Open-Source kanban", "private": true, "scripts": { diff --git a/sandstorm-pkgdef.capnp b/sandstorm-pkgdef.capnp index 461b8b43..f9574568 100644 --- a/sandstorm-pkgdef.capnp +++ b/sandstorm-pkgdef.capnp @@ -22,10 +22,10 @@ const pkgdef :Spk.PackageDefinition = ( appTitle = (defaultText = "Wekan"), # The name of the app as it is displayed to the user. - appVersion = 197, + appVersion = 198, # Increment this for every release. - appMarketingVersion = (defaultText = "1.95.0~2018-12-21"), + appMarketingVersion = (defaultText = "1.96.0~2018-12-24"), # Human-readable presentation of the app version. minUpgradableAppVersion = 0, @@ -254,7 +254,6 @@ const myCommand :Spk.Manifest.Command = ( (key = "OAUTH2_TOKEN_ENDPOINT", value=""), (key = "LDAP_ENABLE", value="false"), (key = "SANDSTORM", value = "1"), - (key = "METEOR_SETTINGS", value = "{\"public\": {\"sandstorm\": true}}"), - (key = "DEFAULT_AUTHENTICATION_METHOD", value = "") + (key = "METEOR_SETTINGS", value = "{\"public\": {\"sandstorm\": true}}") ] ); |