diff options
author | Andrés Manelli <andresmanelli@gmail.com> | 2019-03-08 21:13:41 +0100 |
---|---|---|
committer | Andrés Manelli <andresmanelli@gmail.com> | 2019-03-08 21:13:41 +0100 |
commit | 2ec1664408d9515b5ca77fbb46ef99208eb8cff0 (patch) | |
tree | b86f849a7403ef81c720d8f4ff66318f7866b585 | |
parent | 97822f35fd6365e5631c5488e8ee595f76ab4e34 (diff) | |
download | wekan-2ec1664408d9515b5ca77fbb46ef99208eb8cff0.tar.gz wekan-2ec1664408d9515b5ca77fbb46ef99208eb8cff0.tar.bz2 wekan-2ec1664408d9515b5ca77fbb46ef99208eb8cff0.zip |
Fix removed checklistItem activity => dangling activities created
-rw-r--r-- | models/checklistItems.js | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/models/checklistItems.js b/models/checklistItems.js index 30e57aec..c46fe9bd 100644 --- a/models/checklistItems.js +++ b/models/checklistItems.js @@ -99,17 +99,6 @@ function itemCreation(userId, doc) { } function itemRemover(userId, doc) { - const card = Cards.findOne(doc.cardId); - const boardId = card.boardId; - Activities.insert({ - userId, - activityType: 'removedChecklistItem', - cardId: doc.cardId, - boardId, - checklistId: doc.checklistId, - checklistItemId: doc._id, - checklistItemName:doc.title, - }); Activities.remove({ checklistItemId: doc._id, }); @@ -206,8 +195,19 @@ if (Meteor.isServer) { itemCreation(userId, doc); }); - ChecklistItems.after.remove((userId, doc) => { + ChecklistItems.before.remove((userId, doc) => { itemRemover(userId, doc); + const card = Cards.findOne(doc.cardId); + const boardId = card.boardId; + Activities.insert({ + userId, + activityType: 'removedChecklistItem', + cardId: doc.cardId, + boardId, + checklistId: doc.checklistId, + checklistItemId: doc._id, + checklistItemName:doc.title, + }); }); } |