From 4b22c1f99cb05be5ca187f2fd70ee2664c34de57 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Thu, 3 Sep 2015 10:49:36 -0400 Subject: Upgrading ESLint and adding some more rules. Refactoring to meet these new rules --- web/react/.eslintrc | 35 +++++++++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 6 deletions(-) (limited to 'web/react/.eslintrc') diff --git a/web/react/.eslintrc b/web/react/.eslintrc index ab000e941..41558aacd 100644 --- a/web/react/.eslintrc +++ b/web/react/.eslintrc @@ -4,7 +4,9 @@ "jsx": true, "blockBindings": true, "modules": true, - "classes": true + "classes": true, + "arrowFunctions": true, + "defaultParams": true, }, "plugins": [ "react" @@ -34,16 +36,16 @@ "no-inner-declarations": 0, "no-invalid-regexp": 2, "no-irregular-whitespace": 2, + "no-unexpected-multiline": 2, "no-unreachable": 2, "valid-typeof": 2, - "no-unexpected-multiline": 2, "block-scoped-var": 1, "complexity": [0, 8], "consistent-return": 2, "curly": [2, "all"], - "dot-notation": 2, "dot-location": [2, "object"], + "dot-notation": 2, "eqeqeq": [2, "smart"], "guard-for-in": 1, "no-alert": 1, @@ -78,8 +80,9 @@ "no-self-compare": 2, "no-sequences": 2, "no-throw-literal": 2, - "no-unused-expressions": 2, "no-undef-init": 2, + "no-unused-expressions": 2, + "no-useless-concat": 0, "no-void": 2, "no-warning-comments": 0, "no-with": 2, @@ -135,12 +138,31 @@ "space-unary-ops": [2, { "words": true, "nonwords": false }], "wrap-regex": 2, + // ES6 stuff + "arrow-parens": [2, "always"], + "arrow-spacing": [2, { "before": true, "after": true }], + "constructor-super": 2, + "generator-star-spacing": [2, {"before": false, "after": true}], + "no-class-assign": 2, + "no-const-assign": 2, + "no-dupe-class-members": 2, + "no-this-before-super": 2, + "no-var": 0, + "object-shorthand": [0, "always"], + "prefer-arrow-callback": 0, + "prefer-const": 0, + "prefer-spread": 2, + "prefer-reflect": 0, + "prefer-template": 0, + "require-yield": 0, + // React Specific "react/display-name": [2, { "acceptTranspilerName": true }], "react/jsx-boolean-value": [2, "always"], + "react/jsx-closing-bracket-location": [2, { "location": "tag-aligned" }], "react/jsx-curly-spacing": [2, "never"], + "react/jsx-indent-props": [2, 4], "react/jsx-max-props-per-line": [2, { "maximum": 1 }], - // SOON "react/jsx-indent-props": [2, 4], "react/jsx-no-duplicate-props": [2, { "ignoreCase": false }], "react/jsx-no-literals": 0, "react/jsx-no-undef": 2, @@ -151,10 +173,11 @@ "react/no-did-mount-set-state": 2, "react/no-did-update-set-state": 2, "react/no-multi-comp": 2, + "react/no-set-state": 0, "react/no-unknown-property": 2, "react/prop-types": 2, - "react/sort-comp": 0, "react/self-closing-comp": 2, + "react/sort-comp": 0, "react/wrap-multilines": 2 } } -- cgit v1.2.3-1-g7c22 From d064f1d4ff7720133fdaf4fb6c5eed7f0585bba3 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Thu, 3 Sep 2015 11:06:29 -0400 Subject: Upgrading some warnings to errors so Travis won't accept them. Enabling some more rules as warnings. --- web/react/.eslintrc | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) (limited to 'web/react/.eslintrc') diff --git a/web/react/.eslintrc b/web/react/.eslintrc index 41558aacd..663d73fae 100644 --- a/web/react/.eslintrc +++ b/web/react/.eslintrc @@ -23,16 +23,16 @@ "rules": { "comma-dangle": [2, "never"], "no-cond-assign": [2, "except-parens"], - "no-console": 1, - "no-constant-condition": 1, - "no-debugger": 1, + "no-console": 2, + "no-constant-condition": 2, + "no-debugger": 2, "no-dupe-args": 2, "no-dupe-keys": 2, "no-duplicate-case": 2, - "no-empty": 1, - "no-ex-assign": 1, + "no-empty": 2, + "no-ex-assign": 2, "no-extra-semi": 2, - "no-func-assign": 1, + "no-func-assign": 2, "no-inner-declarations": 0, "no-invalid-regexp": 2, "no-irregular-whitespace": 2, @@ -40,19 +40,19 @@ "no-unreachable": 2, "valid-typeof": 2, - "block-scoped-var": 1, - "complexity": [0, 8], + "block-scoped-var": 2, + "complexity": [1, 8], "consistent-return": 2, "curly": [2, "all"], "dot-location": [2, "object"], "dot-notation": 2, "eqeqeq": [2, "smart"], - "guard-for-in": 1, - "no-alert": 1, + "guard-for-in": 2, + "no-alert": 2, "no-array-constructor": 2, "no-caller": 2, - "no-div-regex": 1, - "no-else-return": 1, + "no-div-regex": 2, + "no-else-return": 2, "no-eval": 2, "no-extend-native": 2, "no-extra-bind": 2, @@ -60,7 +60,7 @@ "no-implied-eval": 2, "no-iterator": 2, "no-labels": 2, - "no-lone-blocks": 1, + "no-lone-blocks": 2, "no-loop-func": 2, "no-multi-spaces": [2, { "exceptions": { "Property": false } }], "no-multi-str": 0, @@ -82,9 +82,9 @@ "no-throw-literal": 2, "no-undef-init": 2, "no-unused-expressions": 2, - "no-useless-concat": 0, + "no-useless-concat": 1, "no-void": 2, - "no-warning-comments": 0, + "no-warning-comments": 1, "no-with": 2, "radix": 2, "vars-on-top": 0, @@ -148,13 +148,13 @@ "no-dupe-class-members": 2, "no-this-before-super": 2, "no-var": 0, - "object-shorthand": [0, "always"], - "prefer-arrow-callback": 0, - "prefer-const": 0, + "object-shorthand": [1, "always"], + "prefer-arrow-callback": 1, + "prefer-const": 1, "prefer-spread": 2, - "prefer-reflect": 0, - "prefer-template": 0, - "require-yield": 0, + "prefer-reflect": 1, + "prefer-template": 1, + "require-yield": 2, // React Specific "react/display-name": [2, { "acceptTranspilerName": true }], @@ -164,7 +164,7 @@ "react/jsx-indent-props": [2, 4], "react/jsx-max-props-per-line": [2, { "maximum": 1 }], "react/jsx-no-duplicate-props": [2, { "ignoreCase": false }], - "react/jsx-no-literals": 0, + "react/jsx-no-literals": 1, "react/jsx-no-undef": 2, "react/jsx-quotes": [2, "single", "avoid-escape"], "react/jsx-uses-react": 2, -- cgit v1.2.3-1-g7c22 From 21a6c84988808bd31867ea8d0d2f7ff73a068cb9 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Thu, 3 Sep 2015 15:03:11 -0400 Subject: Turning off eslint perfer-templates that was mistakinly turned on --- web/react/.eslintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web/react/.eslintrc') diff --git a/web/react/.eslintrc b/web/react/.eslintrc index 663d73fae..53cc75913 100644 --- a/web/react/.eslintrc +++ b/web/react/.eslintrc @@ -153,7 +153,7 @@ "prefer-const": 1, "prefer-spread": 2, "prefer-reflect": 1, - "prefer-template": 1, + "prefer-template": 0, "require-yield": 2, // React Specific -- cgit v1.2.3-1-g7c22