From 1d9c14485470d2399bb3ee578c11b0c50fb640c7 Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Fri, 27 Jul 2018 11:17:29 -0400 Subject: s/mlog/log/ in apiRPCClient (#9171) We never actually initialized `log` on apiRPCClient, and it can't log without making an RPC call anyway, so just switch to logging errors from the plugin to STDERR instead. --- plugin/client_rpc.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'plugin/client_rpc.go') diff --git a/plugin/client_rpc.go b/plugin/client_rpc.go index f5831445e..4ea7c1cdc 100644 --- a/plugin/client_rpc.go +++ b/plugin/client_rpc.go @@ -56,7 +56,6 @@ func (p *hooksPlugin) Client(b *plugin.MuxBroker, client *rpc.Client) (interface type apiRPCClient struct { client *rpc.Client - log *mlog.Logger } type apiRPCServer struct { @@ -198,7 +197,7 @@ func (g *apiRPCClient) LoadPluginConfiguration(dest interface{}) error { _args := &Z_LoadPluginConfigurationArgsArgs{} _returns := &Z_LoadPluginConfigurationArgsReturns{} if err := g.client.Call("Plugin.LoadPluginConfiguration", _args, _returns); err != nil { - g.log.Error("RPC call to LoadPluginConfiguration API failed.", mlog.Err(err)) + log.Printf("RPC call to LoadPluginConfiguration API failed: %s", err.Error()) } if err := json.Unmarshal(_returns.A, dest); err != nil { g.log.Error("LoadPluginConfiguration API failed to unmarshal.", mlog.Err(err)) -- cgit v1.2.3-1-g7c22