From 7cefef6d21fa76de0683d2fe9ff56a6e28816628 Mon Sep 17 00:00:00 2001 From: Joram Wilander Date: Tue, 5 Dec 2017 18:19:33 -0500 Subject: Hash key for plugin store and limit id length (#7933) --- model/manifest.go | 5 +++-- model/plugin_key_value.go | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) (limited to 'model') diff --git a/model/manifest.go b/model/manifest.go index 121d3e0d2..03d78f84e 100644 --- a/model/manifest.go +++ b/model/manifest.go @@ -102,8 +102,9 @@ type PluginSettingsSchema struct { // help_text: When true, an extra thing will be enabled! // default: false type Manifest struct { - // The id is a globally unique identifier that represents your plugin. Reverse-DNS notation - // using a name you control is a good option. For example, "com.mycompany.myplugin". + // The id is a globally unique identifier that represents your plugin. Ids are limited + // to 190 characters. Reverse-DNS notation using a name you control is a good option. + // For example, "com.mycompany.myplugin". Id string `json:"id" yaml:"id"` // The name to be displayed for the plugin. diff --git a/model/plugin_key_value.go b/model/plugin_key_value.go index ceb216c2a..b7a7731c4 100644 --- a/model/plugin_key_value.go +++ b/model/plugin_key_value.go @@ -9,8 +9,8 @@ import ( ) const ( - KEY_VALUE_PLUGIN_ID_MAX_RUNES = 100 - KEY_VALUE_KEY_MAX_RUNES = 100 + KEY_VALUE_PLUGIN_ID_MAX_RUNES = 190 + KEY_VALUE_KEY_MAX_RUNES = 50 ) type PluginKeyValue struct { -- cgit v1.2.3-1-g7c22