From 3e462713debd5c992aa071bed902110bed88ec67 Mon Sep 17 00:00:00 2001 From: Jesse Haka Date: Tue, 2 Oct 2018 09:00:50 +0300 Subject: if EnableLinkPreviews not enabled, do not call url (#9461) --- api4/system_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'api4/system_test.go') diff --git a/api4/system_test.go b/api4/system_test.go index c66e08976..32fadd380 100644 --- a/api4/system_test.go +++ b/api4/system_test.go @@ -717,6 +717,12 @@ func TestRedirectLocation(t *testing.T) { th := Setup().InitBasic().InitSystemAdmin() defer th.TearDown() Client := th.Client + enableLinkPreviews := *th.App.Config().ServiceSettings.EnableLinkPreviews + defer func() { + th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ServiceSettings.EnableLinkPreviews = enableLinkPreviews }) + }() + + *th.App.Config().ServiceSettings.EnableLinkPreviews = true _, resp := th.SystemAdminClient.GetRedirectLocation("https://mattermost.com/", "") CheckNoError(t, resp) @@ -730,6 +736,19 @@ func TestRedirectLocation(t *testing.T) { t.Errorf("Expected %v but got %v.", expected, actual) } + *th.App.Config().ServiceSettings.EnableLinkPreviews = false + actual, resp = th.SystemAdminClient.GetRedirectLocation("https://mattermost.com/", "") + CheckNoError(t, resp) + assert.Equal(t, actual, "") + + actual, resp = th.SystemAdminClient.GetRedirectLocation("", "") + CheckNoError(t, resp) + assert.Equal(t, actual, "") + + actual, resp = th.SystemAdminClient.GetRedirectLocation(mockBitlyLink, "") + CheckNoError(t, resp) + assert.Equal(t, actual, "") + Client.Logout() _, resp = Client.GetRedirectLocation("", "") CheckUnauthorizedStatus(t, resp) -- cgit v1.2.3-1-g7c22