From 5f9a28ed6f45dd02a0aa2b4220717c29567a7ba8 Mon Sep 17 00:00:00 2001 From: enahum Date: Wed, 17 May 2017 17:33:44 -0400 Subject: Ability to use OAuth login from mobile (#6432) --- api4/oauth.go | 33 ++++++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-) (limited to 'api4/oauth.go') diff --git a/api4/oauth.go b/api4/oauth.go index 33c166da4..626a6065f 100644 --- a/api4/oauth.go +++ b/api4/oauth.go @@ -35,6 +35,7 @@ func InitOAuth() { // API version independent OAuth as a client endpoints BaseRoutes.Root.Handle("/oauth/{service:[A-Za-z0-9]+}/complete", ApiHandler(completeOAuth)).Methods("GET") BaseRoutes.Root.Handle("/oauth/{service:[A-Za-z0-9]+}/login", ApiHandler(loginWithOAuth)).Methods("GET") + BaseRoutes.Root.Handle("/oauth/{service:[A-Za-z0-9]+}/mobile_login", ApiHandler(mobileLoginWithOAuth)).Methods("GET") BaseRoutes.Root.Handle("/oauth/{service:[A-Za-z0-9]+}/signup", ApiHandler(signupWithOAuth)).Methods("GET") // Old endpoints for backwards compatibility, needed to not break SSO for any old setups @@ -417,9 +418,6 @@ func completeOAuth(c *Context, w http.ResponseWriter, r *http.Request) { } else if action == model.OAUTH_ACTION_SSO_TO_EMAIL { redirectUrl = app.GetProtocol(r) + "://" + r.Host + "/claim?email=" + url.QueryEscape(props["email"]) - } else if action == model.OAUTH_ACTION_MOBILE { - ReturnStatusOK(w) - return } else { session, err := app.DoLogin(w, r, user, "") if err != nil { @@ -432,7 +430,12 @@ func completeOAuth(c *Context, w http.ResponseWriter, r *http.Request) { redirectUrl = c.GetSiteURLHeader() } - http.Redirect(w, r, redirectUrl, http.StatusTemporaryRedirect) + if action == model.OAUTH_ACTION_MOBILE { + ReturnStatusOK(w) + return + } else { + http.Redirect(w, r, redirectUrl, http.StatusTemporaryRedirect) + } } func loginWithOAuth(c *Context, w http.ResponseWriter, r *http.Request) { @@ -450,7 +453,27 @@ func loginWithOAuth(c *Context, w http.ResponseWriter, r *http.Request) { return } - if authUrl, err := app.GetOAuthLoginEndpoint(c.Params.Service, teamId, redirectTo, loginHint); err != nil { + if authUrl, err := app.GetOAuthLoginEndpoint(c.Params.Service, teamId, model.OAUTH_ACTION_LOGIN, redirectTo, loginHint); err != nil { + c.Err = err + return + } else { + http.Redirect(w, r, authUrl, http.StatusFound) + } +} + +func mobileLoginWithOAuth(c *Context, w http.ResponseWriter, r *http.Request) { + c.RequireService() + if c.Err != nil { + return + } + + teamId, err := app.GetTeamIdFromQuery(r.URL.Query()) + if err != nil { + c.Err = err + return + } + + if authUrl, err := app.GetOAuthLoginEndpoint(c.Params.Service, teamId, model.OAUTH_ACTION_MOBILE, "", ""); err != nil { c.Err = err return } else { -- cgit v1.2.3-1-g7c22