From b9092ca2f56b0fa2b8ec7719c2ec5cfe5a21a6c9 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Tue, 20 Dec 2016 16:55:22 +0100 Subject: Fix API Get channels for a user returns users' dm channels with blank teamid (#4748) * fix API Get channels for a user returns users' dm channels with blank team ID add check in the context.go add suggestion made adjustment per review and support from @joram * update tests * add check if needd user or admin permissions * update per review --- api/team_test.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'api/team_test.go') diff --git a/api/team_test.go b/api/team_test.go index c4bcb1868..52b23e1ba 100644 --- a/api/team_test.go +++ b/api/team_test.go @@ -766,15 +766,11 @@ func TestGetTeamStats(t *testing.T) { } } - if result, err := th.SystemAdminClient.GetTeamStats("junk"); err != nil { - t.Fatal(err) + if _, err := th.SystemAdminClient.GetTeamStats("junk"); err == nil { + t.Fatal("should fail invalid teamid") } else { - if result.Data.(*model.TeamStats).TotalMemberCount != 0 { - t.Fatal("wrong count") - } - - if result.Data.(*model.TeamStats).ActiveMemberCount != 0 { - t.Fatal("wrong count") + if err.Id != "store.sql_team.get.find.app_error" { + t.Fatal("wrong error. Got: " + err.Id) } } -- cgit v1.2.3-1-g7c22