From 420bc367fa10047dc40c7e5165f6e8f05438957c Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Tue, 1 Nov 2016 16:16:16 -0400 Subject: Fixing permissions issue when deleting slash commands (#4414) --- api/command.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api/command.go') diff --git a/api/command.go b/api/command.go index 5cf9d730b..e71661a67 100644 --- a/api/command.go +++ b/api/command.go @@ -415,7 +415,7 @@ func deleteCommand(c *Context, w http.ResponseWriter, r *http.Request) { c.Err = result.Err return } else { - if c.TeamId != result.Data.(*model.Command).TeamId || (c.Session.UserId != result.Data.(*model.Command).CreatorId && HasPermissionToCurrentTeamContext(c, model.PERMISSION_MANAGE_OTHERS_SLASH_COMMANDS)) { + if c.TeamId != result.Data.(*model.Command).TeamId || (c.Session.UserId != result.Data.(*model.Command).CreatorId && !HasPermissionToCurrentTeamContext(c, model.PERMISSION_MANAGE_OTHERS_SLASH_COMMANDS)) { c.LogAudit("fail - inappropriate permissions") c.Err = model.NewLocAppError("deleteCommand", "api.command.delete.app_error", nil, "user_id="+c.Session.UserId) return -- cgit v1.2.3-1-g7c22