From 8c8f1bdd633f3afe158dd8c02130a36a5ca9be9d Mon Sep 17 00:00:00 2001 From: JoramWilander Date: Thu, 1 Oct 2015 14:10:52 -0400 Subject: Add model test for outgoing webhooks. --- model/incoming_webhook_test.go | 82 +++++++++++++++++++++++++++++++++++ model/outgoing_webhook_test.go | 97 ++++++++++++++++++++++++++++++++++++++++++ model/webhook_test.go | 82 ----------------------------------- 3 files changed, 179 insertions(+), 82 deletions(-) create mode 100644 model/incoming_webhook_test.go create mode 100644 model/outgoing_webhook_test.go delete mode 100644 model/webhook_test.go diff --git a/model/incoming_webhook_test.go b/model/incoming_webhook_test.go new file mode 100644 index 000000000..5297d7d90 --- /dev/null +++ b/model/incoming_webhook_test.go @@ -0,0 +1,82 @@ +// Copyright (c) 2015 Mattermost, Inc. All Rights Reserved. +// See License.txt for license information. + +package model + +import ( + "strings" + "testing" +) + +func TestIncomingWebhookJson(t *testing.T) { + o := IncomingWebhook{Id: NewId()} + json := o.ToJson() + ro := IncomingWebhookFromJson(strings.NewReader(json)) + + if o.Id != ro.Id { + t.Fatal("Ids do not match") + } +} + +func TestIncomingWebhookIsValid(t *testing.T) { + o := IncomingWebhook{} + + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.Id = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.CreateAt = GetMillis() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.UpdateAt = GetMillis() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.UserId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.UserId = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.ChannelId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.ChannelId = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.TeamId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.TeamId = NewId() + if err := o.IsValid(); err != nil { + t.Fatal(err) + } +} + +func TestIncomingWebhookPreSave(t *testing.T) { + o := IncomingWebhook{} + o.PreSave() +} + +func TestIncomingWebhookPreUpdate(t *testing.T) { + o := IncomingWebhook{} + o.PreUpdate() +} diff --git a/model/outgoing_webhook_test.go b/model/outgoing_webhook_test.go new file mode 100644 index 000000000..2ca48c291 --- /dev/null +++ b/model/outgoing_webhook_test.go @@ -0,0 +1,97 @@ +// Copyright (c) 2015 Spinpunch, Inc. All Rights Reserved. +// See License.txt for license information. + +package model + +import ( + "strings" + "testing" +) + +func TestOutgoingWebhookJson(t *testing.T) { + o := OutgoingWebhook{Id: NewId()} + json := o.ToJson() + ro := OutgoingWebhookFromJson(strings.NewReader(json)) + + if o.Id != ro.Id { + t.Fatal("Ids do not match") + } +} + +func TestOutgoingWebhookIsValid(t *testing.T) { + o := OutgoingWebhook{} + + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.Id = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.CreateAt = GetMillis() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.UpdateAt = GetMillis() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.CreatorId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.CreatorId = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.Token = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.Token = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.ChannelId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.ChannelId = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.TeamId = "123" + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.TeamId = NewId() + if err := o.IsValid(); err == nil { + t.Fatal("should be invalid") + } + + o.CallbackURLs = []string{"http://nowhere.com/"} + if err := o.IsValid(); err != nil { + t.Fatal(err) + } +} + +func TestOutgoingWebhookPreSave(t *testing.T) { + o := OutgoingWebhook{} + o.PreSave() +} + +func TestOutgoingWebhookPreUpdate(t *testing.T) { + o := OutgoingWebhook{} + o.PreUpdate() +} diff --git a/model/webhook_test.go b/model/webhook_test.go deleted file mode 100644 index 5297d7d90..000000000 --- a/model/webhook_test.go +++ /dev/null @@ -1,82 +0,0 @@ -// Copyright (c) 2015 Mattermost, Inc. All Rights Reserved. -// See License.txt for license information. - -package model - -import ( - "strings" - "testing" -) - -func TestIncomingWebhookJson(t *testing.T) { - o := IncomingWebhook{Id: NewId()} - json := o.ToJson() - ro := IncomingWebhookFromJson(strings.NewReader(json)) - - if o.Id != ro.Id { - t.Fatal("Ids do not match") - } -} - -func TestIncomingWebhookIsValid(t *testing.T) { - o := IncomingWebhook{} - - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.Id = NewId() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.CreateAt = GetMillis() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.UpdateAt = GetMillis() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.UserId = "123" - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.UserId = NewId() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.ChannelId = "123" - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.ChannelId = NewId() - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.TeamId = "123" - if err := o.IsValid(); err == nil { - t.Fatal("should be invalid") - } - - o.TeamId = NewId() - if err := o.IsValid(); err != nil { - t.Fatal(err) - } -} - -func TestIncomingWebhookPreSave(t *testing.T) { - o := IncomingWebhook{} - o.PreSave() -} - -func TestIncomingWebhookPreUpdate(t *testing.T) { - o := IncomingWebhook{} - o.PreUpdate() -} -- cgit v1.2.3-1-g7c22