From 4da0257bd52f20734d6d98c33ea5d824d98abbf5 Mon Sep 17 00:00:00 2001 From: Joram Wilander Date: Thu, 7 Dec 2017 17:03:11 -0500 Subject: Add diagnostic for zoom plugin (#7958) --- app/diagnostics.go | 9 +++++++++ app/diagnostics_test.go | 14 ++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/app/diagnostics.go b/app/diagnostics.go index b977afcee..e19be15c6 100644 --- a/app/diagnostics.go +++ b/app/diagnostics.go @@ -110,6 +110,14 @@ func pluginSetting(pluginSettings *model.PluginSettings, plugin, key string, def return defaultValue } +func pluginActivated(pluginStates map[string]*model.PluginState, pluginId string) bool { + state, ok := pluginStates[pluginId] + if !ok { + return false + } + return state.Enable +} + func (a *App) trackActivity() { var userCount int64 var activeUserCount int64 @@ -460,6 +468,7 @@ func (a *App) trackConfig() { SendDiagnostic(TRACK_CONFIG_PLUGIN, map[string]interface{}{ "enable_jira": pluginSetting(&cfg.PluginSettings, "jira", "enabled", false), + "enable_zoom": pluginActivated(cfg.PluginSettings.PluginStates, "zoom"), "enable": *cfg.PluginSettings.Enable, "enable_uploads": *cfg.PluginSettings.EnableUploads, }) diff --git a/app/diagnostics_test.go b/app/diagnostics_test.go index 9b884fd43..0d1c7acd8 100644 --- a/app/diagnostics_test.go +++ b/app/diagnostics_test.go @@ -43,6 +43,20 @@ func TestPluginSetting(t *testing.T) { assert.Equal(t, "asd", pluginSetting(settings, "test", "qwe", "asd")) } +func TestPluginActivated(t *testing.T) { + states := map[string]*model.PluginState{ + "foo": &model.PluginState{ + Enable: true, + }, + "bar": &model.PluginState{ + Enable: false, + }, + } + assert.True(t, pluginActivated(states, "foo")) + assert.False(t, pluginActivated(states, "bar")) + assert.False(t, pluginActivated(states, "none")) +} + func TestDiagnostics(t *testing.T) { th := Setup().InitBasic() defer th.TearDown() -- cgit v1.2.3-1-g7c22