diff options
author | Harrison Healey <harrisonmhealey@gmail.com> | 2018-02-12 12:56:46 -0500 |
---|---|---|
committer | Harrison Healey <harrisonmhealey@gmail.com> | 2018-02-13 09:57:23 -0500 |
commit | 3fef21e350737c235e6dfc2d9f35311d65290c3e (patch) | |
tree | c9dffab5215f785534b948513f7b335bec07c945 /app | |
parent | c1b49f8b77e0e75afcc6cf4dc0f1c36569824151 (diff) | |
download | chat-3fef21e350737c235e6dfc2d9f35311d65290c3e.tar.gz chat-3fef21e350737c235e6dfc2d9f35311d65290c3e.tar.bz2 chat-3fef21e350737c235e6dfc2d9f35311d65290c3e.zip |
ICU-753 Added unit tests for messages with only push notifications
Diffstat (limited to 'app')
-rw-r--r-- | app/notification.go | 2 | ||||
-rw-r--r-- | app/notification_test.go | 24 |
2 files changed, 25 insertions, 1 deletions
diff --git a/app/notification.go b/app/notification.go index 83debe584..8d8e72cf9 100644 --- a/app/notification.go +++ b/app/notification.go @@ -656,7 +656,7 @@ func (a *App) getPushNotificationMessage(postMessage string, wasMentioned bool, } // If the post only has images then push an appropriate message - if len(message) == 0 && hasFiles { + if len(postMessage) == 0 && hasFiles { if channelType == model.CHANNEL_DIRECT { message = senderName + userLocale("api.post.send_notifications_and_forget.push_image_only_dm") } else { diff --git a/app/notification_test.go b/app/notification_test.go index 2b7b260c4..cc501fbd0 100644 --- a/app/notification_test.go +++ b/app/notification_test.go @@ -1345,6 +1345,30 @@ func TestGetPushNotificationMessage(t *testing.T) { ExpectedMessage: "user sent you a direct message", ExpectedCategory: model.CATEGORY_CAN_REPLY, }, + "only files, public channel": { + HasFiles: true, + ChannelType: model.CHANNEL_OPEN, + ExpectedMessage: "user uploaded one or more files in channel", + ExpectedCategory: model.CATEGORY_CAN_REPLY, + }, + "only files, private channel": { + HasFiles: true, + ChannelType: model.CHANNEL_PRIVATE, + ExpectedMessage: "user uploaded one or more files in channel", + ExpectedCategory: model.CATEGORY_CAN_REPLY, + }, + "only files, group message channel": { + HasFiles: true, + ChannelType: model.CHANNEL_GROUP, + ExpectedMessage: "user uploaded one or more files in channel", + ExpectedCategory: model.CATEGORY_CAN_REPLY, + }, + "only files, direct message channel": { + HasFiles: true, + ChannelType: model.CHANNEL_DIRECT, + ExpectedMessage: "user uploaded one or more files in a direct message", + ExpectedCategory: model.CATEGORY_CAN_REPLY, + }, } { t.Run(name, func(t *testing.T) { locale := tc.Locale |