diff options
author | Sudheer <sudheer.105@gmail.com> | 2018-06-27 18:38:58 +0530 |
---|---|---|
committer | Jesús Espino <jespinog@gmail.com> | 2018-06-27 15:08:58 +0200 |
commit | 9abd74c5e31625c1c11fcedafc44f8aadc4ecdb0 (patch) | |
tree | 4228353fab52052a2df7657fc56fc0519a6e6996 /app/command_join_test.go | |
parent | 1e6994a2abf037c1fa8872ab34de1b0627cb1ab0 (diff) | |
download | chat-9abd74c5e31625c1c11fcedafc44f8aadc4ecdb0.tar.gz chat-9abd74c5e31625c1c11fcedafc44f8aadc4ecdb0.tar.bz2 chat-9abd74c5e31625c1c11fcedafc44f8aadc4ecdb0.zip |
MM-10910 fix join and open channel commands to work with tilde (#8984)
* MM-10910 fix join and open channel commands to work with tilde
* Fix lint
* Add basic tests for command_join
Diffstat (limited to 'app/command_join_test.go')
-rw-r--r-- | app/command_join_test.go | 88 |
1 files changed, 88 insertions, 0 deletions
diff --git a/app/command_join_test.go b/app/command_join_test.go new file mode 100644 index 000000000..77574217b --- /dev/null +++ b/app/command_join_test.go @@ -0,0 +1,88 @@ +// Copyright (c) 2018-present Mattermost, Inc. All Rights Reserved. +// See License.txt for license information. + +package app + +import ( + "testing" + "github.com/mattermost/mattermost-server/model" + "github.com/nicksnyder/go-i18n/i18n" + "github.com/stretchr/testify/assert" +) + +func TestJoinCommandNoChannel(t *testing.T) { + th := Setup().InitBasic() + defer th.TearDown() + + if testing.Short() { + t.SkipNow() + } + + cmd := &JoinProvider{} + resp := cmd.DoCommand(th.App, &model.CommandArgs{ + T: i18n.IdentityTfunc(), + UserId: th.BasicUser2.Id, + SiteURL: "http://test.url", + TeamId: th.BasicTeam.Id, + }, "asdsad") + + assert.Equal(t, "api.command_join.list.app_error", resp.Text) +} + +func TestJoinCommandForExistingChannel(t *testing.T) { + th := Setup().InitBasic() + defer th.TearDown() + + if testing.Short() { + t.SkipNow() + } + + channel2, _ := th.App.CreateChannel(&model.Channel{ + DisplayName: "AA", + Name: "aa" + model.NewId() + "a", + Type: model.CHANNEL_OPEN, + TeamId: th.BasicTeam.Id, + CreatorId: th.BasicUser.Id, + }, false) + + + cmd := &JoinProvider{} + resp := cmd.DoCommand(th.App, &model.CommandArgs{ + T: i18n.IdentityTfunc(), + UserId: th.BasicUser2.Id, + SiteURL: "http://test.url", + TeamId: th.BasicTeam.Id, + }, channel2.Name) + + assert.Equal(t, "", resp.Text) + assert.Equal(t, "http://test.url/"+th.BasicTeam.Name+"/channels/"+channel2.Name, resp.GotoLocation) +} + +func TestJoinCommandWithTilde(t *testing.T) { + th := Setup().InitBasic() + defer th.TearDown() + + if testing.Short() { + t.SkipNow() + } + + channel2, _ := th.App.CreateChannel(&model.Channel{ + DisplayName: "AA", + Name: "aa" + model.NewId() + "a", + Type: model.CHANNEL_OPEN, + TeamId: th.BasicTeam.Id, + CreatorId: th.BasicUser.Id, + }, false) + + + cmd := &JoinProvider{} + resp := cmd.DoCommand(th.App, &model.CommandArgs{ + T: i18n.IdentityTfunc(), + UserId: th.BasicUser2.Id, + SiteURL: "http://test.url", + TeamId: th.BasicTeam.Id, + }, "~"+channel2.Name) + + assert.Equal(t, "", resp.Text) + assert.Equal(t, "http://test.url/"+th.BasicTeam.Name+"/channels/"+channel2.Name, resp.GotoLocation) +} |