diff options
author | Saturnino Abril <saturnino.abril@gmail.com> | 2017-04-26 23:11:32 +0900 |
---|---|---|
committer | Harrison Healey <harrisonmhealey@gmail.com> | 2017-04-26 10:11:32 -0400 |
commit | 6fa7082833812c734aeef8ad24477823ee766f1b (patch) | |
tree | bc70138ff3a71cfffcdf9fe20794735a87e478e7 /api4/reaction_test.go | |
parent | f9502ff14bbb31aa835540c14725bbebdf0c340d (diff) | |
download | chat-6fa7082833812c734aeef8ad24477823ee766f1b.tar.gz chat-6fa7082833812c734aeef8ad24477823ee766f1b.tar.bz2 chat-6fa7082833812c734aeef8ad24477823ee766f1b.zip |
fix reaction's name validation with + sign in it (#6221)
Diffstat (limited to 'api4/reaction_test.go')
-rw-r--r-- | api4/reaction_test.go | 41 |
1 files changed, 37 insertions, 4 deletions
diff --git a/api4/reaction_test.go b/api4/reaction_test.go index b80c96118..c973c9a13 100644 --- a/api4/reaction_test.go +++ b/api4/reaction_test.go @@ -70,6 +70,20 @@ func TestSaveReaction(t *testing.T) { t.Fatal("should have save multiple reactions") } + // saving special case + reaction.EmojiName = "+1" + + rr, resp = Client.SaveReaction(reaction) + CheckNoError(t, resp) + + if rr.EmojiName != reaction.EmojiName { + t.Fatal("EmojiName did not match") + } + + if reactions, err := app.GetReactionsForPost(postId); err != nil && len(reactions) != 3 { + t.Fatal("should have save multiple reactions") + } + reaction.PostId = GenerateTestId() _, resp = Client.SaveReaction(reaction) @@ -244,22 +258,41 @@ func TestDeleteReaction(t *testing.T) { t.Fatal("should have deleted 1 reaction only") } - // deleting a reaction made by another user + // deleting one reaction of name +1 r3 := &model.Reaction{ + UserId: userId, + PostId: postId, + EmojiName: "+1", + } + + app.SaveReactionForPost(r3) + if reactions, err := app.GetReactionsForPost(postId); err != nil || len(reactions) != 2 { + t.Fatal("didn't save reactions correctly") + } + + _, resp = Client.DeleteReaction(r3) + CheckNoError(t, resp) + + if reactions, err := app.GetReactionsForPost(postId); err != nil || len(reactions) != 1 || *reactions[0] != *r1 { + t.Fatal("should have deleted 1 reaction only") + } + + // deleting a reaction made by another user + r4 := &model.Reaction{ UserId: user2Id, PostId: postId, EmojiName: "smile_", } th.LoginBasic2() - app.SaveReactionForPost(r3) + app.SaveReactionForPost(r4) if reactions, err := app.GetReactionsForPost(postId); err != nil || len(reactions) != 2 { t.Fatal("didn't save reaction correctly") } th.LoginBasic() - ok, resp = Client.DeleteReaction(r3) + ok, resp = Client.DeleteReaction(r4) CheckForbiddenStatus(t, resp) if ok { @@ -310,7 +343,7 @@ func TestDeleteReaction(t *testing.T) { _, resp = th.SystemAdminClient.DeleteReaction(r1) CheckNoError(t, resp) - _, resp = th.SystemAdminClient.DeleteReaction(r3) + _, resp = th.SystemAdminClient.DeleteReaction(r4) CheckNoError(t, resp) if reactions, err := app.GetReactionsForPost(postId); err != nil || len(reactions) != 0 { |