1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
|
import os
import copy
import stat
import unittest
import lxml.etree
from mock import Mock, MagicMock, patch
import Bcfg2.Client.Tools
from Bcfg2.Client.Tools.POSIX.base import *
from Test__init import get_posix_object
try:
import selinux
has_selinux = True
except ImportError:
has_selinux = False
try:
import posix1e
has_acls = True
except ImportError:
has_acls = False
def call(*args, **kwargs):
""" the Mock call object is a fairly recent addition, but it's
very very useful, so we create our own function to create Mock
calls """
return (args, kwargs)
def get_posixtool_object(posix=None):
if posix is None:
posix = get_posix_object()
return POSIXTool(posix.logger, posix.setup, posix.config)
class TestPOSIXTool(unittest.TestCase):
def test_fully_specified(self):
# fully_specified should do no checking on the abstract
# POSIXTool object
ptool = get_posixtool_object()
self.assertTrue(ptool.fully_specified(Mock()))
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._verify_metadata")
def test_verify(self, mock_verify):
entry = lxml.etree.Element("Path", name="/test", type="file")
ptool = get_posixtool_object()
with patch('os.stat') as mock_stat, patch('os.walk') as mock_walk:
mock_stat.return_value = MagicMock()
mock_verify.return_value = False
self.assertFalse(ptool.verify(entry, []))
mock_verify.assert_called_with(entry)
mock_verify.reset_mock()
mock_verify.return_value = True
self.assertTrue(ptool.verify(entry, []))
mock_verify.assert_called_with(entry)
mock_verify.reset_mock()
entry.set("recursive", "true")
walk_rv = [("/", ["dir1", "dir2"], ["file1", "file2"]),
("/dir1", ["dir3"], []),
("/dir2", [], ["file3", "file4"])]
mock_walk.return_value = walk_rv
self.assertTrue(ptool.verify(entry, []))
mock_walk.assert_called_with(entry.get("name"))
all_verifies = [call(entry)]
for root, dirs, files in walk_rv:
all_verifies.extend([call(entry, path=os.path.join(root, p))
for p in dirs + files])
self.assertItemsEqual(mock_verify.call_args_list, all_verifies)
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._set_perms")
def test_install(self, mock_set_perms):
entry = lxml.etree.Element("Path", name="/test", type="file")
ptool = get_posixtool_object()
mock_set_perms.return_value = True
self.assertTrue(ptool.install(entry))
mock_set_perms.assert_called_with(entry)
mock_set_perms.reset_mock()
entry.set("recursive", "true")
with patch('os.walk') as mock_walk:
walk_rv = [("/", ["dir1", "dir2"], ["file1", "file2"]),
("/dir1", ["dir3"], []),
("/dir2", [], ["file3", "file4"])]
mock_walk.return_value = walk_rv
mock_set_perms.return_value = True
self.assertTrue(ptool.install(entry))
mock_walk.assert_called_with(entry.get("name"))
all_set_perms = [call(entry)]
for root, dirs, files in walk_rv:
all_set_perms.extend([call(entry,
path=os.path.join(root, p))
for p in dirs + files])
self.assertItemsEqual(mock_set_perms.call_args_list,
all_set_perms)
mock_walk.reset_mock()
mock_set_perms.reset_mock()
def set_perms_rv(entry, path=None):
if path == '/dir2/file3':
return False
else:
return True
mock_set_perms.side_effect = set_perms_rv
self.assertFalse(ptool.install(entry))
mock_walk.assert_called_with(entry.get("name"))
self.assertItemsEqual(mock_set_perms.call_args_list,
all_set_perms)
@patch("os.unlink")
@patch("shutil.rmtree")
def test_exists(self, mock_rmtree, mock_unlink):
entry = lxml.etree.Element("Path", name="/etc/foo", type="file")
ptool = get_posixtool_object()
with patch('os.lstat') as mock_lstat, \
patch("os.path.isdir") as mock_isdir:
mock_lstat.side_effect = OSError
self.assertFalse(ptool._exists(entry))
mock_lstat.assert_called_with(entry.get('name'))
self.assertFalse(mock_unlink.called)
mock_lstat.reset_mock()
mock_unlink.reset_mock()
rv = MagicMock()
mock_lstat.return_value = rv
mock_lstat.side_effect = None
self.assertEqual(ptool._exists(entry), rv)
mock_lstat.assert_called_with(entry.get('name'))
self.assertFalse(mock_unlink.called)
mock_lstat.reset_mock()
mock_unlink.reset_mock()
mock_isdir.return_value = False
self.assertFalse(ptool._exists(entry, remove=True))
mock_isdir.assert_called_with(entry.get('name'))
mock_lstat.assert_called_with(entry.get('name'))
mock_unlink.assert_called_with(entry.get('name'))
self.assertFalse(mock_rmtree.called)
mock_lstat.reset_mock()
mock_isdir.reset_mock()
mock_unlink.reset_mock()
mock_rmtree.reset_mock()
mock_isdir.return_value = True
self.assertFalse(ptool._exists(entry, remove=True))
mock_isdir.assert_called_with(entry.get('name'))
mock_lstat.assert_called_with(entry.get('name'))
mock_rmtree.assert_called_with(entry.get('name'))
self.assertFalse(mock_unlink.called)
mock_isdir.reset_mock()
mock_lstat.reset_mock()
mock_unlink.reset_mock()
mock_rmtree.reset_mock()
mock_rmtree.side_effect = OSError
self.assertEqual(ptool._exists(entry, remove=True), rv)
mock_isdir.assert_called_with(entry.get('name'))
mock_lstat.assert_called_with(entry.get('name'))
mock_rmtree.assert_called_with(entry.get('name'))
self.assertFalse(mock_unlink.called)
@patch("os.chown")
@patch("os.chmod")
@patch("os.utime")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_entry_uid")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_entry_gid")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._set_acls")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._set_secontext")
def test_set_perms(self, mock_set_secontext, mock_set_acls, mock_norm_gid,
mock_norm_uid, mock_utime, mock_chmod, mock_chown):
ptool = get_posixtool_object()
def reset():
mock_set_secontext.reset_mock()
mock_set_acls.reset_mock()
mock_norm_gid.reset_mock()
mock_norm_uid.reset_mock()
mock_chmod.reset_mock()
mock_chown.reset_mock()
mock_utime.reset_mock()
entry = lxml.etree.Element("Path", name="/etc/foo", to="/etc/bar",
type="symlink")
mock_set_acls.return_value = True
mock_set_secontext.return_value = True
self.assertTrue(ptool._set_perms(entry))
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
entry = lxml.etree.Element("Path", name="/etc/foo", owner="owner",
group="group", perms="644", type="file")
mock_norm_uid.return_value = 10
mock_norm_gid.return_value = 100
reset()
self.assertTrue(ptool._set_perms(entry))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with(entry.get("name"), 10, 100)
mock_chmod.assert_called_with(entry.get("name"),
int(entry.get("perms"), 8))
self.assertFalse(mock_utime.called)
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
reset()
mtime = 1344459042
entry.set("mtime", str(mtime))
self.assertTrue(ptool._set_perms(entry))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with(entry.get("name"), 10, 100)
mock_chmod.assert_called_with(entry.get("name"),
int(entry.get("perms"), 8))
mock_utime.assert_called_with(entry.get("name"), (mtime, mtime))
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
reset()
self.assertTrue(ptool._set_perms(entry, path='/etc/bar'))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with('/etc/bar', 10, 100)
mock_chmod.assert_called_with('/etc/bar', int(entry.get("perms"), 8))
mock_utime.assert_called_with(entry.get("name"), (mtime, mtime))
mock_set_secontext.assert_called_with(entry, path='/etc/bar')
mock_set_acls.assert_called_with(entry, path='/etc/bar')
# test dev_type modification of perms, failure of chown
reset()
def chown_rv(path, owner, group):
if owner == 0 and group == 0:
return True
else:
raise KeyError
os.chown.side_effect = chown_rv
entry.set("type", "device")
entry.set("dev_type", device_map.keys()[0])
self.assertFalse(ptool._set_perms(entry))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with(entry.get("name"), 0, 0)
mock_chmod.assert_called_with(entry.get("name"),
int(entry.get("perms"), 8) | device_map.values()[0])
mock_utime.assert_called_with(entry.get("name"), (mtime, mtime))
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
# test failure of chmod
reset()
os.chown.side_effect = None
os.chmod.side_effect = OSError
entry.set("type", "file")
del entry.attrib["dev_type"]
self.assertFalse(ptool._set_perms(entry))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with(entry.get("name"), 10, 100)
mock_chmod.assert_called_with(entry.get("name"),
int(entry.get("perms"), 8))
mock_utime.assert_called_with(entry.get("name"), (mtime, mtime))
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
# test that even when everything fails, we try to do it all.
# e.g., when chmod fails, we still try to apply acls, set
# selinux context, etc.
reset()
os.chown.side_effect = OSError
os.utime.side_effect = OSError
mock_set_acls.return_value = False
mock_set_secontext.return_value = False
self.assertFalse(ptool._set_perms(entry))
mock_norm_uid.assert_called_with(entry)
mock_norm_gid.assert_called_with(entry)
mock_chown.assert_called_with(entry.get("name"), 10, 100)
mock_chmod.assert_called_with(entry.get("name"),
int(entry.get("perms"), 8))
mock_utime.assert_called_with(entry.get("name"), (mtime, mtime))
mock_set_secontext.assert_called_with(entry, path=entry.get("name"))
mock_set_acls.assert_called_with(entry, path=entry.get("name"))
@unittest.skipUnless(has_acls, "ACLS not found, skipping")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_uid")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_gid")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._list_entry_acls")
def test_set_acls(self, mock_list_entry_acls, mock_norm_gid, mock_norm_uid):
entry = lxml.etree.Element("Path", name="/etc/foo", type="file")
ptool = get_posixtool_object()
# disable acls for the initial test
Bcfg2.Client.Tools.POSIX.base.has_acls = False
self.assertTrue(ptool._set_acls(entry))
Bcfg2.Client.Tools.POSIX.base.has_acls = True
# build a set of file ACLs to return from posix1e.ACL(file=...)
file_acls = []
acl = Mock()
acl.tag_type = posix1e.ACL_USER
acl.name = "remove"
file_acls.append(acl)
acl = Mock()
acl.tag_type = posix1e.ACL_GROUP
acl.name = "remove"
file_acls.append(acl)
acl = Mock()
acl.tag_type = posix1e.ACL_MASK
acl.name = "keep"
file_acls.append(acl)
remove_acls = [a for a in file_acls if a.name == "remove"]
# build a set of ACLs listed on the entry as returned by
# _list_entry_acls()
entry_acls = {("default", posix1e.ACL_USER, "user"): 7,
("access", posix1e.ACL_GROUP, "group"): 5}
mock_list_entry_acls.return_value = entry_acls
mock_norm_uid.return_value = 10
mock_norm_gid.return_value = 100
with patch("posix1e.ACL") as mock_ACL, \
patch("posix1e.Entry") as mock_Entry, \
patch("os.path.isdir") as mock_isdir:
# set up the unreasonably complex return value for
# posix1e.ACL(), which has three separate uses
fileacl_rv = MagicMock()
fileacl_rv.valid.return_value = True
fileacl_rv.__iter__.return_value = iter(file_acls)
filedef_rv = MagicMock()
filedef_rv.valid.return_value = True
filedef_rv.__iter__.return_value = iter(file_acls)
acl_rv = MagicMock()
def mock_acl_rv(file=None, filedef=None, acl=None):
if file:
return fileacl_rv
elif filedef:
return filedef_rv
elif acl:
return acl_rv
# set up the equally unreasonably complex return value for
# posix1e.Entry, which returns a new entry and adds it to
# an ACL, so we have to track the Mock objects it returns.
# why can't they just have an acl.add_entry() method?!?
acl_entries = []
def mock_entry_rv(acl):
rv = MagicMock()
rv.acl = acl
rv.permset = set()
acl_entries.append(rv)
return rv
mock_Entry.side_effect = mock_entry_rv
def reset():
mock_isdir.reset_mock()
mock_ACL.reset_mock()
mock_Entry.reset_mock()
fileacl_rv.reset_mock()
# test fs mounted noacl
mock_ACL.side_effect = IOError(95, "Operation not permitted")
self.assertFalse(ptool._set_acls(entry))
# test other error
reset()
mock_ACL.side_effect = IOError
self.assertFalse(ptool._set_acls(entry))
reset()
mock_ACL.side_effect = mock_acl_rv
mock_isdir.return_value = True
self.assertTrue(ptool._set_acls(entry))
self.assertItemsEqual(mock_ACL.call_args_list,
[call(file=entry.get("name")),
call(filedef=entry.get("name"))])
self.assertItemsEqual(fileacl_rv.delete_entry.call_args_list,
[call(a) for a in remove_acls])
self.assertItemsEqual(filedef_rv.delete_entry.call_args_list,
[call(a) for a in remove_acls])
mock_list_entry_acls.assert_called_with(entry)
mock_norm_uid.assert_called_with("user")
mock_norm_gid.assert_called_with("group")
fileacl_rv.calc_mask.assert_any_call()
fileacl_rv.applyto.assert_called_with(entry.get("name"),
posix1e.ACL_TYPE_ACCESS)
filedef_rv.calc_mask.assert_any_call()
filedef_rv.applyto.assert_called_with(entry.get("name"),
posix1e.ACL_TYPE_DEFAULT)
# build tuples of the Entry objects that were added to acl
# and defaacl so they're easier to compare for equality
added_acls = []
for acl in acl_entries:
added_acls.append((acl.acl, acl.tag_type, acl.qualifier,
sum(acl.permset)))
self.assertItemsEqual(added_acls,
[(filedef_rv, posix1e.ACL_USER, 10, 7),
(fileacl_rv, posix1e.ACL_GROUP, 100, 5)])
reset()
# have to reassign these because they're iterators, and
# they've already been iterated over once
fileacl_rv.__iter__.return_value = iter(file_acls)
filedef_rv.__iter__.return_value = iter(file_acls)
mock_list_entry_acls.reset_mock()
mock_norm_uid.reset_mock()
mock_norm_gid.reset_mock()
mock_isdir.return_value = False
acl_entries = []
self.assertTrue(ptool._set_acls(entry, path="/bin/bar"))
mock_ACL.assert_called_with(file="/bin/bar")
self.assertItemsEqual(fileacl_rv.delete_entry.call_args_list,
[call(a) for a in remove_acls])
mock_list_entry_acls.assert_called_with(entry)
mock_norm_gid.assert_called_with("group")
fileacl_rv.calc_mask.assert_any_call()
fileacl_rv.applyto.assert_called_with("/bin/bar",
posix1e.ACL_TYPE_ACCESS)
added_acls = []
for acl in acl_entries:
added_acls.append((acl.acl, acl.tag_type, acl.qualifier,
sum(acl.permset)))
self.assertItemsEqual(added_acls,
[(fileacl_rv, posix1e.ACL_GROUP, 100, 5)])
@unittest.skipUnless(has_selinux, "SELinux not found, skipping")
def test_set_secontext(self):
entry = lxml.etree.Element("Path", name="/etc/foo", type="file")
ptool = get_posixtool_object()
# disable selinux for the initial test
Bcfg2.Client.Tools.POSIX.base.has_selinux = False
self.assertTrue(ptool._set_secontext(entry))
Bcfg2.Client.Tools.POSIX.base.has_selinux = True
with patch("selinux.restorecon") as mock_restorecon, \
patch("selinux.lsetfilecon") as mock_lsetfilecon:
# no context given
self.assertTrue(ptool._set_secontext(entry))
self.assertFalse(mock_restorecon.called)
self.assertFalse(mock_lsetfilecon.called)
mock_restorecon.reset_mock()
mock_lsetfilecon.reset_mock()
entry.set("secontext", "__default__")
self.assertTrue(ptool._set_secontext(entry))
mock_restorecon.assert_called_with(entry.get("name"))
self.assertFalse(mock_lsetfilecon.called)
mock_restorecon.reset_mock()
mock_lsetfilecon.reset_mock()
mock_lsetfilecon.return_value = 0
entry.set("secontext", "foo_t")
self.assertTrue(ptool._set_secontext(entry))
self.assertFalse(mock_restorecon.called)
mock_lsetfilecon.assert_called_with(entry.get("name"), "foo_t")
mock_restorecon.reset_mock()
mock_lsetfilecon.reset_mock()
mock_lsetfilecon.return_value = 1
self.assertFalse(ptool._set_secontext(entry))
self.assertFalse(mock_restorecon.called)
mock_lsetfilecon.assert_called_with(entry.get("name"), "foo_t")
@patch("grp.getgrnam")
def test_norm_gid(self, mock_getgrnam):
ptool = get_posixtool_object()
self.assertEqual(5, ptool._norm_gid("5"))
self.assertFalse(mock_getgrnam.called)
mock_getgrnam.reset_mock()
mock_getgrnam.return_value = ("group", "x", 5, [])
self.assertEqual(5, ptool._norm_gid("group"))
mock_getgrnam.assert_called_with("group")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_gid")
def test_norm_entry_gid(self, mock_norm_gid):
entry = lxml.etree.Element("Path", name="/test", type="file",
group="group", owner="user")
ptool = get_posixtool_object()
mock_norm_gid.return_value = 10
self.assertEqual(10, ptool._norm_entry_gid(entry))
mock_norm_gid.assert_called_with(entry.get("group"))
mock_norm_gid.reset_mock()
mock_norm_gid.side_effect = KeyError
self.assertEqual(0, ptool._norm_entry_gid(entry))
mock_norm_gid.assert_called_with(entry.get("group"))
@patch("pwd.getpwnam")
def test_norm_uid(self, mock_getpwnam):
ptool = get_posixtool_object()
self.assertEqual(5, ptool._norm_uid("5"))
self.assertFalse(mock_getpwnam.called)
mock_getpwnam.reset_mock()
mock_getpwnam.return_value = ("user", "x", 5, 5, "User", "/home/user",
"/bin/zsh")
self.assertEqual(5, ptool._norm_uid("user"))
mock_getpwnam.assert_called_with("user")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_uid")
def test_norm_entry_uid(self, mock_norm_uid):
entry = lxml.etree.Element("Path", name="/test", type="file",
group="group", owner="user")
ptool = get_posixtool_object()
mock_norm_uid.return_value = 10
self.assertEqual(10, ptool._norm_entry_uid(entry))
mock_norm_uid.assert_called_with(entry.get("owner"))
mock_norm_uid.reset_mock()
mock_norm_uid.side_effect = KeyError
self.assertEqual(0, ptool._norm_entry_uid(entry))
mock_norm_uid.assert_called_with(entry.get("owner"))
def test_norm_acl_perms(self):
ptool = get_posixtool_object()
# there's basically no reasonably way to test the Permset
# object parsing feature without writing our own Mock object
# that re-implements Permset.test(). silly pylibacl won't let
# us create standalone Entry or Permset objects.
ptool = get_posixtool_object()
self.assertEqual(5, ptool._norm_acl_perms("5"))
self.assertEqual(0, ptool._norm_acl_perms("55"))
self.assertEqual(5, ptool._norm_acl_perms("rx"))
self.assertEqual(5, ptool._norm_acl_perms("r-x"))
self.assertEqual(6, ptool._norm_acl_perms("wr-"))
self.assertEqual(0, ptool._norm_acl_perms("rwrw"))
self.assertEqual(0, ptool._norm_acl_perms("-"))
self.assertEqual(0, ptool._norm_acl_perms("a"))
self.assertEqual(6, ptool._norm_acl_perms("rwa"))
self.assertEqual(4, ptool._norm_acl_perms("rr"))
def test__gather_data(self):
path = '/test'
ptool = get_posixtool_object()
# have to use context manager version of patch here because
# os.stat must be unpatched when we instantiate the object to
# make pkgutil.walk_packages() work
with patch('os.stat') as mock_stat:
mock_stat.side_effect = OSError
self.assertFalse(ptool._gather_data(path)[0])
mock_stat.assert_called_with(path)
mock_stat.reset_mock()
mock_stat.side_effect = None
# create a return value
stat_rv = MagicMock()
def stat_getitem(key):
if int(key) == stat.ST_UID:
return 0
elif int(key) == stat.ST_GID:
return 10
elif int(key) == stat.ST_MODE:
# return extra bits in the mode to emulate a device
# and ensure that they're stripped
return int('060660', 8)
stat_rv.__getitem__ = Mock(side_effect=stat_getitem)
mock_stat.return_value = stat_rv
# disable selinux and acls for this call -- we test them
# separately so that we can skip those tests as appropriate
states = (Bcfg2.Client.Tools.POSIX.base.has_selinux,
Bcfg2.Client.Tools.POSIX.base.has_acls)
Bcfg2.Client.Tools.POSIX.base.has_selinux = False
Bcfg2.Client.Tools.POSIX.base.has_acls = False
self.assertEqual(ptool._gather_data(path),
(stat_rv, '0', '10', '0660', None, None))
Bcfg2.Client.Tools.POSIX.base.has_selinux, \
Bcfg2.Client.Tools.POSIX.base.has_acls = states
mock_stat.assert_called_with(path)
@unittest.skipUnless(has_selinux, "SELinux not found, skipping")
def test__gather_data_selinux(self):
context = 'system_u:object_r:root_t:s0'
path = '/test'
ptool = get_posixtool_object()
with patch("selinux.getfilecon") as mock_getfilecon, \
patch('os.stat') as mock_stat:
mock_getfilecon.return_value = [len(context) + 1, context]
mock_stat.return_value = MagicMock()
# disable acls for this call and test them separately
state = Bcfg2.Client.Tools.POSIX.base.has_acls
Bcfg2.Client.Tools.POSIX.base.has_acls = False
self.assertEqual(ptool._gather_data(path)[4], 'root_t')
Bcfg2.Client.Tools.POSIX.base.has_acls = state
mock_getfilecon.assert_called_with(path)
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._list_file_acls")
@unittest.skipUnless(has_acls, "ACLS not found, skipping")
def test__gather_data_acls(self, mock_list_file_acls):
acls = {("default", posix1e.ACL_USER, "testuser"): "rwx",
("access", posix1e.ACL_GROUP, "testgroup"): "rx"}
mock_list_file_acls.return_value = acls
path = '/test'
ptool = get_posixtool_object()
with patch('os.stat') as mock_stat:
mock_stat.return_value = MagicMock()
# disable selinux for this call and test it separately
state = Bcfg2.Client.Tools.POSIX.base.has_selinux
Bcfg2.Client.Tools.POSIX.base.has_selinux = False
self.assertItemsEqual(ptool._gather_data(path)[5], acls)
Bcfg2.Client.Tools.POSIX.base.has_selinux = state
mock_list_file_acls.assert_called_with(path)
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._verify_acls")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._gather_data")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_entry_uid")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._norm_entry_gid")
def test_verify_metadata(self, mock_norm_gid, mock_norm_uid,
mock_gather_data, mock_verify_acls):
entry = lxml.etree.Element("Path", name="/test", type="file",
group="group", owner="user", perms="664",
secontext='etc_t')
# _verify_metadata() mutates the entry, so we keep a backup so we
# can start fresh every time
orig_entry = copy.deepcopy(entry)
ptool = get_posixtool_object()
def reset():
mock_gather_data.reset_mock()
mock_norm_uid.reset_mock()
mock_norm_gid.reset_mock()
return copy.deepcopy(orig_entry)
# test nonexistent file
mock_gather_data.return_value = (False, None, None, None, None, None)
self.assertFalse(ptool._verify_metadata(entry))
self.assertEqual(entry.get("current_exists", "").lower(), "false")
mock_gather_data.assert_called_with(entry.get("name"))
# expected data. tuple of attr, return value index, value
expected = [('current_owner', 1, '0'),
('current_group', 2, '10'),
('current_perms', 3, '0664'),
('current_secontext', 4, 'etc_t')]
mock_norm_uid.return_value = 0
mock_norm_gid.return_value = 10
gather_data_rv = [MagicMock(), None, None, None, None, []]
for attr, idx, val in expected:
gather_data_rv[idx] = val
entry = reset()
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertTrue(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry, path=entry.get("name"))
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
self.assertEqual(entry.get(attr), val)
# test when secontext is None
entry = reset()
gather_data_rv[4] = None
sestate = Bcfg2.Client.Tools.POSIX.base.has_selinux
Bcfg2.Client.Tools.POSIX.base.has_selinux = False
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertTrue(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry, path=entry.get("name"))
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
if attr != 'current_secontext':
self.assertEqual(entry.get(attr), val)
Bcfg2.Client.Tools.POSIX.base.has_selinux = sestate
gather_data_rv = [MagicMock(), None, None, None, None, []]
for attr, idx, val in expected:
gather_data_rv[idx] = val
mock_gather_data.return_value = tuple(gather_data_rv)
mtime = 1344430414
entry = reset()
entry.set("mtime", str(mtime))
stat_rv = MagicMock()
stat_rv.__getitem__.return_value = mtime
gather_data_rv[0] = stat_rv
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertTrue(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry, path=entry.get("name"))
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
self.assertEqual(entry.get(attr), val)
self.assertEqual(entry.get("current_mtime"), str(mtime))
# failure modes for each checked datum. tuple of changed attr,
# return value index, new (failing) value
failures = [('current_owner', 1, '10'),
('current_group', 2, '100'),
('current_perms', 3, '0660')]
if has_selinux:
failures.append(('current_secontext', 4, 'root_t'))
for fail_attr, fail_idx, fail_val in failures:
entry = reset()
entry.set("mtime", str(mtime))
gather_data_rv = [stat_rv, None, None, None, None, []]
for attr, idx, val in expected:
gather_data_rv[idx] = val
gather_data_rv[fail_idx] = fail_val
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertFalse(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry, path=entry.get("name"))
self.assertEqual(entry.get("current_exists", 'true'), 'true')
self.assertEqual(entry.get(fail_attr), fail_val)
for attr, idx, val in expected:
if attr != fail_attr:
self.assertEqual(entry.get(attr), val)
self.assertEqual(entry.get("current_mtime"), str(mtime))
# failure mode for mtime
fail_mtime = 1344431162
entry = reset()
entry.set("mtime", str(mtime))
fail_stat_rv = MagicMock()
fail_stat_rv.__getitem__.return_value = fail_mtime
gather_data_rv = [fail_stat_rv, None, None, None, None, []]
for attr, idx, val in expected:
gather_data_rv[idx] = val
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertFalse(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry, path=entry.get("name"))
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
self.assertEqual(entry.get(attr), val)
self.assertEqual(entry.get("current_mtime"), str(fail_mtime))
if has_selinux:
# test success and failure for __default__ secontext
entry = reset()
entry.set("mtime", str(mtime))
entry.set("secontext", "__default__")
with patch("selinux.matchpathcon") as mock_matchpathcon:
context1 = "system_u:object_r:etc_t:s0"
context2 = "system_u:object_r:root_t:s0"
mock_matchpathcon.return_value = [1 + len(context1),
context1]
gather_data_rv = [stat_rv, None, None, None, None, []]
for attr, idx, val in expected:
gather_data_rv[idx] = val
mock_gather_data.return_value = tuple(gather_data_rv)
self.assertTrue(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry,
path=entry.get("name"))
mock_matchpathcon.assert_called_with(entry.get("name"), 0)
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
self.assertEqual(entry.get(attr), val)
self.assertEqual(entry.get("current_mtime"), str(mtime))
entry = reset()
entry.set("mtime", str(mtime))
entry.set("secontext", "__default__")
mock_matchpathcon.return_value = [1 + len(context2),
context2]
self.assertFalse(ptool._verify_metadata(entry))
mock_gather_data.assert_called_with(entry.get("name"))
mock_verify_acls.assert_called_with(entry,
path=entry.get("name"))
mock_matchpathcon.assert_called_with(entry.get("name"), 0)
self.assertEqual(entry.get("current_exists", 'true'), 'true')
for attr, idx, val in expected:
self.assertEqual(entry.get(attr), val)
self.assertEqual(entry.get("current_mtime"), str(mtime))
@unittest.skipUnless(has_acls, "ACLS not found, skipping")
def test_list_entry_acls(self):
entry = lxml.etree.Element("Path", name="/test", type="file")
lxml.etree.SubElement(entry, "ACL", scope="user", type="default",
user="user", perms="rwx")
lxml.etree.SubElement(entry, "ACL", scope="group", type="access",
group="group", perms="5")
ptool = get_posixtool_object()
self.assertItemsEqual(ptool._list_entry_acls(entry),
{("default", posix1e.ACL_USER, "user"): 7,
("access", posix1e.ACL_GROUP, "group"): 5})
@unittest.skipUnless(has_acls, "ACLS not found, skipping")
@patch("pwd.getpwuid")
@patch("grp.getgrgid")
def test_list_file_acls(self, mock_getgrgid, mock_getpwuid):
path = '/test'
ptool = get_posixtool_object()
with patch("posix1e.ACL") as mock_ACL, \
patch("os.path.isdir") as mock_isdir:
# build a set of file ACLs to return from posix1e.ACL(file=...)
file_acls = []
acl = Mock()
acl.tag_type = posix1e.ACL_USER
acl.qualifier = 10
# yes, this is a bogus permset. thanks to _norm_acl_perms
# it works and is easier than many of the alternatives.
acl.permset = 'rwx'
file_acls.append(acl)
acl = Mock()
acl.tag_type = posix1e.ACL_GROUP
acl.qualifier = 100
acl.permset = 'rx'
file_acls.append(acl)
acl = Mock()
acl.tag_type = posix1e.ACL_MASK
file_acls.append(acl)
acls = {("access", posix1e.ACL_USER, "user"): 7,
("access", posix1e.ACL_GROUP, "group"): 5}
# set up the unreasonably complex return value for
# posix1e.ACL(), which has two separate uses
fileacl_rv = MagicMock()
fileacl_rv.valid.return_value = True
fileacl_rv.__iter__.return_value = iter(file_acls)
filedef_rv = MagicMock()
filedef_rv.valid.return_value = True
filedef_rv.__iter__.return_value = iter(file_acls)
def mock_acl_rv(file=None, filedef=None):
if file:
return fileacl_rv
elif filedef:
return filedef_rv
# other return values
mock_isdir.return_value = False
mock_getgrgid.return_value = ("group", "x", 5, [])
mock_getpwuid.return_value = ("user", "x", 5, 5, "User",
"/home/user", "/bin/zsh")
def reset():
mock_isdir.reset_mock()
mock_getgrgid.reset_mock()
mock_getpwuid.reset_mock()
mock_ACL.reset_mock()
mock_ACL.side_effect = IOError(95, "Operation not supported")
self.assertItemsEqual(ptool._list_file_acls(path), dict())
reset()
mock_ACL.side_effect = IOError
self.assertItemsEqual(ptool._list_file_acls(path), dict())
reset()
mock_ACL.side_effect = mock_acl_rv
self.assertItemsEqual(ptool._list_file_acls(path), acls)
mock_isdir.assert_called_with(path)
mock_getgrgid.assert_called_with(100)
mock_getpwuid.assert_called_with(10)
mock_ACL.assert_called_with(file=path)
reset()
mock_isdir.return_value = True
fileacl_rv.__iter__.return_value = iter(file_acls)
filedef_rv.__iter__.return_value = iter(file_acls)
defacls = acls
for akey, perms in acls.items():
defacls[('default', akey[1], akey[2])] = perms
self.assertItemsEqual(ptool._list_file_acls(path), defacls)
mock_isdir.assert_called_with(path)
self.assertItemsEqual(mock_getgrgid.call_args_list,
[call(100), call(100)])
self.assertItemsEqual(mock_getpwuid.call_args_list,
[call(10), call(10)])
self.assertItemsEqual(mock_ACL.call_args_list,
[call(file=path), call(filedef=path)])
@unittest.skipUnless(has_acls, "ACLS not found, skipping")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._list_file_acls")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._list_entry_acls")
def test_verify_acls(self, mock_list_entry_acls, mock_list_file_acls):
entry = lxml.etree.Element("Path", name="/test", type="file")
ptool = get_posixtool_object()
# we can't test to make sure that errors get properly sorted
# into (missing, extra, wrong) without refactoring the
# _verify_acls code, and I don't feel like doing that, so eff
# it. let's just test to make sure that failures are
# identified at all for now.
acls = {("access", posix1e.ACL_USER, "user"): 7,
("default", posix1e.ACL_GROUP, "group"): 5}
extra_acls = copy.deepcopy(acls)
extra_acls[("access", posix1e.ACL_USER, "user2")] = 4
mock_list_entry_acls.return_value = acls
mock_list_file_acls.return_value = acls
self.assertTrue(ptool._verify_acls(entry))
mock_list_entry_acls.assert_called_with(entry)
mock_list_file_acls.assert_called_with(entry.get("name"))
# test missing
mock_list_entry_acls.reset_mock()
mock_list_file_acls.reset_mock()
mock_list_file_acls.return_value = extra_acls
self.assertFalse(ptool._verify_acls(entry))
mock_list_entry_acls.assert_called_with(entry)
mock_list_file_acls.assert_called_with(entry.get("name"))
# test extra
mock_list_entry_acls.reset_mock()
mock_list_file_acls.reset_mock()
mock_list_entry_acls.return_value = extra_acls
mock_list_file_acls.return_value = acls
self.assertFalse(ptool._verify_acls(entry))
mock_list_entry_acls.assert_called_with(entry)
mock_list_file_acls.assert_called_with(entry.get("name"))
# test wrong
wrong_acls = copy.deepcopy(extra_acls)
wrong_acls[("access", posix1e.ACL_USER, "user2")] = 5
mock_list_entry_acls.reset_mock()
mock_list_file_acls.reset_mock()
mock_list_entry_acls.return_value = extra_acls
mock_list_file_acls.return_value = wrong_acls
self.assertFalse(ptool._verify_acls(entry))
mock_list_entry_acls.assert_called_with(entry)
mock_list_file_acls.assert_called_with(entry.get("name"))
@patch("os.makedirs")
@patch("os.path.exists")
@patch("Bcfg2.Client.Tools.POSIX.base.POSIXTool._set_perms")
def test_makedirs(self, mock_set_perms, mock_exists, mock_makedirs):
entry = lxml.etree.Element("Path", name="/test/foo/bar",
type="directory")
def reset():
mock_exists.reset_mock()
mock_set_perms.reset_mock()
mock_makedirs.reset_mock()
ptool = get_posixtool_object()
mock_set_perms.return_value = True
def path_exists_rv(path):
if path == "/test":
return True
else:
return False
mock_exists.side_effect = path_exists_rv
self.assertTrue(ptool._makedirs(entry))
self.assertItemsEqual(mock_exists.call_args_list,
[call("/test"), call("/test/foo"),
call("/test/foo/bar")])
self.assertItemsEqual(mock_set_perms.call_args_list,
[call(entry, path="/test/foo"),
call(entry, path="/test/foo/bar")])
mock_makedirs.assert_called_with(entry.get("name"))
reset()
mock_makedirs.side_effect = OSError
self.assertFalse(ptool._makedirs(entry))
self.assertItemsEqual(mock_set_perms.call_args_list,
[call(entry, path="/test/foo"),
call(entry, path="/test/foo/bar")])
reset()
mock_makedirs.side_effect = None
def set_perms_rv(entry, path=None):
if path == '/test/foo':
return False
else:
return True
mock_set_perms.side_effect = set_perms_rv
self.assertFalse(ptool._makedirs(entry))
self.assertItemsEqual(mock_exists.call_args_list,
[call("/test"), call("/test/foo"),
call("/test/foo/bar")])
self.assertItemsEqual(mock_set_perms.call_args_list,
[call(entry, path="/test/foo"),
call(entry, path="/test/foo/bar")])
mock_makedirs.assert_called_with(entry.get("name"))
|