Updated so stats won't include a blank <Bad> entry if the config is clean.

(Logical change 1.188)


git-svn-id: https://svn.mcs.anl.gov/repos/bcfg/trunk/bcfg2@801 ce84e21b-d406-0410-9b95-82705330c041

1 files changed, 9 insertions, 6 deletions

diff --git a/src/lib/Client/Toolset.py b/src/lib/Client/Toolset.py
index 41bcd783d..b3f9426a5 100644
--- a/src/lib/Client/Toolset.py
+++ b/src/lib/Client/Toolset.py
@@ -117,17 +117,20 @@ class Toolset(object):
 
         if len([key for key, val in self.structures.iteritems() if not val]) == 0:
             stats.set('state', 'clean')
+            dirty = 0
         else:
             stats.set('state', 'dirty')
+            dirty = 1
         #stats.set('time', asctime(localtime()))
 
         # List bad elements of the configuration
-        bad_elms = SubElement(stats, "Bad")
-        for elm in [key for key,val in self.states.iteritems() if not val]:
-            if elm.get('name') == None:
-                SubElement(bad_elms, elm.tag)
-            else:
-                SubElement(bad_elms, elm.tag, name=elm.get('name'))
+        if dirty:
+            bad_elms = SubElement(stats, "Bad")
+            for elm in [key for key,val in self.states.iteritems() if not val]:
+                if elm.get('name') == None:
+                    SubElement(bad_elms, elm.tag)
+                else:
+                    SubElement(bad_elms, elm.tag, name=elm.get('name'))
 
         return stats