Merge branch 'master' of git.mcs.anl.gov:bcfg2

1 files changed, 38 insertions, 0 deletions

diff --git a/src/lib/Server/Lint/Pkgmgr.py b/src/lib/Server/Lint/Pkgmgr.py
new file mode 100644
index 000000000..39c601617
--- /dev/null
+++ b/src/lib/Server/Lint/Pkgmgr.py
@@ -0,0 +1,38 @@
+import Bcfg2.Server.Lint
+
+class Pkgmgr(Bcfg2.Server.Lint.ServerPlugin):
+    """ find duplicate Pkgmgr entries with the same priority """
+
+    @Bcfg2.Server.Lint.returnErrors
+    def Run(self):
+        if 'Pkgmgr' not in self.core.plugins:
+            self.logger.info("Pkgmgr server plugin is not enabled, skipping Pkgmgr lint checks")
+            return
+        
+        pset = set()
+        for plist in self.core.plugins['Pkgmgr'].entries.values():
+            if self.HandlesFile(plist.name):
+                xdata = plist.data
+                # get priority, type, group
+                priority = xdata.getroot().get('priority')
+                ptype = xdata.getroot().get('type')
+                for pkg in xdata.findall("//Package"):
+                    if pkg.getparent().tag == 'Group':
+                        grp = pkg.getparent().get('name')
+                        if (type(grp) is not str and
+                            grp.getparent().tag == 'Group'):
+                            pgrp = grp.getparent().get('name')
+                        else:
+                            pgrp = 'none'
+                    else:
+                        grp = 'none'
+                        pgrp = 'none'
+                    ptuple = (pkg.get('name'), priority, ptype, grp, pgrp)
+                    # check if package is already listed with same
+                    # priority, type, grp
+                    if ptuple in pset:
+                        self.LintError("duplicate-package",
+                                       "Duplicate Package %s, priority:%s, type:%s" %
+                                         (pkg.get('name'), priority, ptype))
+                    else:
+                        pset.add(ptuple)